【贡献经历】从使用者到贡献者：我的Kurator开源之旅

# 下载Kurator CLI
wget https://github.com/kurator-dev/kurator/releases/download/v0.4.0/kurator-cli-v0.4.0-linux-amd64.tar.gz
tar -xzf kurator-cli-v0.4.0-linux-amd64.tar.gz
sudo mv kurator /usr/local/bin/

# 安装Cluster Operator
kubectl apply -f https://github.com/kurator-dev/kurator/releases/download/v0.4.0/cluster-operator-install.yaml

## Problem Description
When setting up multi-cluster monitoring with Thanos, the current documentation doesn't provide complete examples for:
1. Object storage configuration for different cloud providers
2. How to configure Thanos Query across multiple clusters
3. Grafana dashboard setup for federated clusters

## Expected Solution
- Add complete configuration examples for AWS S3, Azure Blob Storage, and local MinIO
- Provide step-by-step guide for cross-cluster query configuration
- Include example Grafana dashboards for fleet-level monitoring

**Maintainer A**: Thanks for reporting this! We indeed need to improve the monitoring documentation. Would you be interested in contributing to this part?

**Me**: Definitely! I've successfully set up Thanos across 3 clusters and can share my configuration. Should I create a PR for the documentation?

**Maintainer B**: That would be great! Please follow our contributing guide and we'll be happy to review your PR.

# 克隆仓库
git clone https://github.com/kurator-dev/kurator.git
cd kurator

# 创建功能分支
git checkout -b docs/improve-thanos-monitoring

# 设置开发环境
make build
make test

# 新增的示例：thanos-config.yaml
apiVersion: v1
kind: ConfigMap
metadata:
  name: thanos-objectstore
  namespace: kurator-system
data:
  objectstore.yaml: |
    type: S3
    config:
      bucket: "thanos-bucket"
      endpoint: "s3.amazonaws.com"
      access_key: "${AWS_ACCESS_KEY_ID}"
      secret_key: "${AWS_SECRET_ACCESS_KEY}"
      insecure: false
      signature_version2: false
      put_user_metadata: {}
      http_config:
        idle_conn_timeout: 90s
        response_header_timeout: 2m
      trace:
        enable: false
      part_size: 134217728

#!/bin/bash
# thanos-setup.sh

# 部署Thanos组件到控制平面集群
kubectl apply -f thanos-config.yaml

# 为每个成员集群部署Thanos Sidecar
for cluster in cluster1 cluster2 cluster3; do
    kubectl --context $cluster apply -f thanos-sidecar.yaml
done

# 验证部署
kubectl get pods -n kurator-system -l app=thanos

**Reviewer Comments**:
1. ✅ Documentation structure looks good
2. ⚠️ Please add validation for the environment variables in the script
3. ❌ Need to update the API version to the latest version
4. ✅ Examples are practical and well-explained

# 改进后的脚本片段，添加了环境变量验证
validate_env_vars() {
    local required_vars=("AWS_ACCESS_KEY_ID" "AWS_SECRET_ACCESS_KEY")
    for var in "${required_vars[@]}"; do
        if [ -z "${!var}" ]; then
            echo "Error: $var is not set"
            exit 1
        fi
    done
}

// 原始代码：pkg/controllers/fleet/cluster_status.go
func (r *Reconciler) updateClusterStatus(ctx context.Context, fleet *fleetv1alpha1.Fleet) error {
    clusters, err := r.listClustersForFleet(ctx, fleet)
    if err != nil {
        return err
    }
    
    // 问题：没有处理超时情况
    for _, cluster := range clusters {
        status, err := r.getClusterStatus(ctx, cluster)
        if err != nil {
            continue // 直接跳过，没有重试机制
        }
        // 更新状态...
    }
    return nil
}

// 修复后的代码
func (r *Reconciler) updateClusterStatus(ctx context.Context, fleet *fleetv1alpha1.Fleet) error {
    clusters, err := r.listClustersForFleet(ctx, fleet)
    if err != nil {
        return err
    }
    
    for _, cluster := range clusters {
        // 添加重试逻辑
        var status *clusterStatus
        err := retry.OnError(
            r.retryBackoff,
            func(err error) bool {
                return isRetriableError(err)
            },
            func() error {
                var retryErr error
                status, retryErr = r.getClusterStatus(ctx, cluster)
                return retryErr
            },
        )
        
        if err != nil {
            r.recordClusterError(fleet, cluster.Name, err)
            continue
        }
        
        // 更新集群状态
        if err := r.updateSingleClusterStatus(ctx, fleet, cluster.Name, status); err != nil {
            return err
        }
    }
    return nil
}

// 重试配置
func (r *Reconciler) setupRetryBackoff() {
    r.retryBackoff = wait.Backoff{
        Steps:    3,
        Duration: 100 * time.Millisecond,
        Factor:   2.0,
        Jitter:   0.1,
    }
}

func TestUpdateClusterStatusWithRetry(t *testing.T) {
    testCases := []struct {
        name          string
        mockErrors    []error
        expectSuccess bool
        expectRetries int
    }{
        {
            name:          "success on first try",
            mockErrors:    []error{nil},
            expectSuccess: true,
            expectRetries: 1,
        },
        {
            name:          "success after retry",
            mockErrors:    []error{errors.New("network error"), nil},
            expectSuccess: true,
            expectRetries: 2,
        },
    }
    
    for _, tc := range testCases {
        t.Run(tc.name, func(t *testing.T) {
            // 测试实现...
        })
    }
}

**社区会议议程示例**：
- 新版本发布计划 (v0.5.0)
- 近期PR审查讨论
- 技术方案设计评审
- 新贡献者欢迎和指导

**对新贡献者的建议**：

1. **从简单的开始**：先从文档改进、Bug修复开始
2. **熟悉社区流程**：阅读CONTRIBUTING.md，了解代码规范
3. **积极沟通**：在Issue中明确问题，在PR中及时响应审查意见
4. **保持耐心**：代码审查可能有多轮修改，这是正常流程