blocks|key|1758833|text|我宁愿相信他们这样做有一个合理的解释。例如，为了更容易地实现ArrayAccess。唯一确定的方法就是直接问他们。|type|unstyled|depth|inlineStyleRanges|entityRanges|data|1758834|为了回答你的问题，是的，当我看到第一种方法时，我会退缩。与OOP原则相违背。|1758835|entityMap^0|0|0^^$0|@$1|2|3|4|5|6|7|F|8|@]|9|@]|A|$]]|$1|B|3|C|5|6|7|G|8|@]|9|@]|A|$]]|$1|D|3|-4|5|6|7|H|8|@]|9|@]|A|$]]]|E|$]]

I'd rather believe they had a reasonable explanation for doing it this way. For example, for easier implementation of ArrayAccess. Only way to know for sure is to ask them directly.

To answer your question, yes I cringe when I see the first method. Goes against OOP principles.

blocks|key|1758945|text|jQuery和Kohana走的是一样的路。然而，我认为为and和and创建单独的方法会更好。方法的作用更明显，我认为它在ide中的代码编译中更实用。例如，输入set，就会得到可以设置的所有属性的列表。|type|unstyled|depth|inlineStyleRanges|offset|length|style|CODE|entityRanges|data|1758946|另一个缺点是:如果您想真正将一个值设置为null，该怎么办？这不会起作用，因为null是返回值的标识符，您在设置特定值时受到限制……|1758947|所以这很好，因为你将不得不写得更少，但是嘿，在你的方法前面的三个字母(set/get)是什么？|1758948|entityMap^0|27|3|0|K|4|13|4|0|Z|3|13|3|0^^$0|@$1|2|3|4|5|6|7|L|8|@$9|M|A|N|B|C]]|D|@]|E|$]]|$1|F|3|G|5|6|7|O|8|@$9|P|A|Q|B|C]|$9|R|A|S|B|C]]|D|@]|E|$]]|$1|H|3|I|5|6|7|T|8|@$9|U|A|V|B|C]|$9|W|A|X|B|C]]|D|@]|E|$]]|$1|J|3|-4|5|6|7|Y|8|@]|D|@]|E|$]]]|K|$]]

jQuery goes the same way as Kohana. However I think it's better to create separate methods for setting and getting. It's more obvious what the method does and I think it's more practically in code-completition in your ide. For example you type <code>set</code> and you get a list of all Properties you can set.

Another disadvantage is: what if you want to set a value really to <code>null</code>? This wouldn't work since the <code>null</code> is the identifier for returnin the value, you are restricted in setting specific values...

So it's nice, since you'll have to write less, but hey what are three letters (<code>set</code>/<code>get</code>) in front of your methods?

blocks|key|1972602|text|尽管Kohana在OOP中使用了这种不同寻常的技术，但我认为您应该首先遵循编码约定。但当然，最好对类中的每个属性使用单独的getter和setter。因此，如果有可能使用它们而不打破常规--只要这样做，你就不会错;)。如果你对使用一些OOP技术有疑问，你也可以在这里读到PHP+http://www.ibm.com/developerworks/opensource/library/os-php-7oohabits/中的好习惯。希望它能有所帮助:)|type|unstyled|depth|inlineStyleRanges|entityRanges|offset|length|data|1972603|entityMap|0|LINK|mutability|MUTABLE|url|http://www.ibm.com/developerworks/opensource/library/os-php-7oohabits/^0|3V|1Y|0|0^^$0|@$1|2|3|4|5|6|7|L|8|@]|9|@$A|M|B|N|1|O]]|C|$]]|$1|D|3|-4|5|6|7|P|8|@]|9|@]|C|$]]]|E|$F|$5|G|H|I|C|$J|K]]]]

Despite the fact that Kohana uses such unusual technique for the OOP, I think you should follow coding conventions at first. But of course it's better to use separate getters and setters for every property in your classes. So, if it's possible to use them not breaking the conventions - just do it and you won't be wrong ;) . You can also read here about good habits in PHP OOP - <a href="http://www.ibm.com/developerworks/opensource/library/os-php-7oohabits/" rel="nofollow">http://www.ibm.com/developerworks/opensource/library/os-php-7oohabits/</a> if you've doubted about using some OOP technics. Hope that it'll help :)

blocks|key|1759102|text|我认为这种做法很糟糕，因为它违反了CommandQuerySeparation。设置一个值就是改变状态(命令)。获取一个值就是询问状态(Query)。一个方法不应该同时做两件事，而应该只做一件事。|type|unstyled|depth|inlineStyleRanges|entityRanges|offset|length|data|1759103|此外，当一个方法只被称为用户名时，它的作用也不是很明显，例如，它没有动词，比如get或set。在您的示例中，情况会更糟，因为返回值要么是对象本身，要么是属性值，因此不一致。|1759104|此外，getters+(and+setters)+should+be+used+sparingly，因为他们将很快卷积您的应用程序接口。你拥有的getter和setter越多，该对象的合作者就需要更多关于该对象的知识。如果您发现您的对象询问其他对象有关其内部结构的信息，那么很可能您把责任放错了地方。|1759105|entityMap|0|LINK|mutability|MUTABLE|url|http://martinfowler.com/bliki/CommandQuerySeparation.html|1|http://martinfowler.com/bliki/GetterEradicator.html^0|H|M|0|0|0|3|1A|1|0^^$0|@$1|2|3|4|5|6|7|R|8|@]|9|@$A|S|B|T|1|U]]|C|$]]|$1|D|3|E|5|6|7|V|8|@]|9|@]|C|$]]|$1|F|3|G|5|6|7|W|8|@]|9|@$A|X|B|Y|1|Z]]|C|$]]|$1|H|3|-4|5|6|7|10|8|@]|9|@]|C|$]]]|I|$J|$5|K|L|M|C|$N|O]]|P|$5|K|L|M|C|$N|Q]]]]

I consider this bad practise because it violates <a href="http://martinfowler.com/bliki/CommandQuerySeparation.html" rel="noreferrer">CommandQuerySeparation</a>. Setting a value is changing state (Command). Getting a value is asking for state (Query). A method should not do both, but one thing only.

Also, it's not really obvious what a method does when it's just called username, e.g. does not have a verb, like get or set. This gets even worse in your example, because the return value is either the object itself or the property value, so its not consistent.

Moreover, <a href="http://martinfowler.com/bliki/GetterEradicator.html" rel="noreferrer">getters (and setters) should be used sparingly</a> as they will quickly convolute your API. The more getters and setters you have, the more knowledge about an object is required by collaborators of that object. If you find your objects asking other objects about their internals, chances are you misplaced the responsibilities.

blocks|key|1972775|text|为什么不这样做呢？|type|unstyled|depth|inlineStyleRanges|entityRanges|data|1972776|public+function+someProperty($value+=+null)
{
++++if+(func_num_args()+===+1)+{
++++++++$this->someProperty+=+$value;
++++++++return+$this;
++++}+else+{
++++++++return+$this->someProperty;
++++}
}|code-block|syntax|javascript|1972777|这将是实现组合的getter/setter的唯一正确方法|1972778|entityMap^0|0|0|0^^$0|@$1|2|3|4|5|6|7|K|8|@]|9|@]|A|$]]|$1|B|3|C|5|D|7|L|8|@]|9|@]|A|$E|F]]|$1|G|3|H|5|6|7|M|8|@]|9|@]|A|$]]|$1|I|3|-4|5|6|7|N|8|@]|9|@]|A|$]]]|J|$]]

Why not do it like this?

<pre><code>public function someProperty($value = null)
{
 if (func_num_args() === 1) {
 $this-&gt;someProperty = $value;
 return $this;
 } else {
 return $this-&gt;someProperty;
 }
}
</code></pre>

This would imo be the only correct way to implement a combined getter/setter

While working on a project, I've been making some changes and browsing around existing framework API docs for insight.

While perusing the Kohana docs, I noticed that the getters/setters of any given class are typically combined:

<pre><code>public function someProperty($value = null){
 if(is_null($value){
 return $this-&gt;_someProperty;
 }
 $this-&gt;_someProperty = $value;
 return $this;
}
</code></pre>

Rather than:

<pre><code>public function setSomeProperty($value){
 $this-&gt;_someProperty = $value;
 return $this;
}

public function getSomeProperty(){
 return $this-&gt;_someProperty;
}
</code></pre>

Is there any value in doing this (the former), beyond lessening the method count of a given class? I was always under the understanding that methods (functions in general) should be more descriptive of an action. Do other experienced developers cringe, even a tiny bit, when they see this?

I was just surprised to see a popular framework use such conventions (I haven't used Kohana of course)

Independent getter/setter methods, or combined?

jQuery

当我在一个项目中工作时，我一直在做一些修改，浏览现有的框架API文档以获得洞察力。在仔细阅读Kohana文档时，我注意到任何给定类的getter/setter通常是组合在一起的：public function someProperty($value = null){    if(is_null($value){    ...

问独立的getter/setter方法，还是组合的？
EN

社区

活动

资源

关于

腾讯云开发者

热门产品

热门推荐

更多推荐

问独立的getter/setter方法，还是组合的？EN

社区

活动

资源

关于

腾讯云开发者

热门产品

热门推荐

更多推荐

问独立的getter/setter方法，还是组合的？
EN