首页
学习
活动
专区
工具
TVP
发布
社区首页 >问答首页 >为什么在C中使用UDP套接字接收文件时会出现一些垃圾字节?

为什么在C中使用UDP套接字接收文件时会出现一些垃圾字节?
EN

Stack Overflow用户
提问于 2017-12-07 17:13:00
回答 1查看 194关注 0票数 -1

我用C语言编写了一个客户端/服务器程序,客户端将文件发送到服务器。它可以工作,但一些垃圾字节被添加到接收到的文件中的1400个字节的位置。我尝试了一个文本文件,在发送之前,我将内存设置为0。为什么是垃圾字节?

代码如下:

macro.h

代码语言:javascript
复制
#ifndef MACRO_H
#define MACRO_H

#include <stdio.h>
#include <errno.h>
#include <stdint.h>


#define SERV_PORT 49312
#define MAXLINE   1400

#define END_FLAG "================END"

#define abort_on_error(cond, msg) do {                                          \
    if (cond) {                                                                 \
        fprintf(stderr, "%s (errno=%d [%s])\n", msg, errno, strerror(errno));   \
        exit(EXIT_FAILURE);                                                     \
    }                                                                           \
} while (0)

struct pkt {
    // struct sockaddr_in addr;
    // int sockfd;
    uint16_t seq_num;
    uint32_t status;
    uint8_t data[MAXLINE];
};

typedef struct pkt PACK;

#endif // MACRO_H

client.c

代码语言:javascript
复制
#include <stdio.h>
#include <stdlib.h>
#include <unistd.h>
#include <string.h>
#include <arpa/inet.h>
#include <sys/socket.h>
#include <fcntl.h>

#include "macro.h"

int main(int argc, char **argv)
{
    int sockfd, n, count = 0;
    struct sockaddr_in servaddr;
    // char buf[MAXLINE];
    char *target, *path;
    FILE *file;
    PACK packet;
    long filesize;

    bzero(&servaddr, sizeof(servaddr));
    servaddr.sin_family = AF_INET;
    servaddr.sin_port = htons(SERV_PORT);
    inet_pton(AF_INET, argv[1], &servaddr.sin_addr);

    sockfd = socket(AF_INET, SOCK_DGRAM, 0);

    path = argv[2];
    target = argv[3];

    packet.seq_num = 0;
    packet.status = 0;
    memset(packet.data, 0, sizeof(packet.data));
    memcpy(packet.data, target, strlen(target));

    abort_on_error(sendto(sockfd, (struct pkt *) &packet, sizeof(packet), 0, (struct sockaddr *) &servaddr, sizeof(servaddr)) == -1,
                    "sendto() filename error");

    memset(packet.data, 0, sizeof(packet.data));
    abort_on_error(recvfrom(sockfd, &packet, sizeof(packet), 0, NULL, NULL) == -1, "recvfrom() ok error");
    if (!strncmp((const char *) packet.data, "ok", 2)) {
        printf("Filename sent.\n");
    }

    file = fopen(path, "r");
    abort_on_error(file == NULL, "fopen() error");

    fseek(file, 0L, SEEK_END);
    filesize = ftell(file);
    printf("filesize: %ld\n", filesize);
    fseek(file, 0L, SEEK_SET);
    memset(packet.data, 0, sizeof(packet.data));
    sprintf((char *) packet.data, "%ld", filesize);

    abort_on_error(sendto(sockfd, (struct pkt *) &packet, sizeof(packet), 0, (struct sockaddr *) &servaddr, sizeof(servaddr)) == -1,
                        "sendto() data error");

    memset(packet.data, 0, sizeof(packet.data));
    while ((n = fread(packet.data, sizeof(char), MAXLINE, file))) {
        // packet.data[n] = '\0';
        // printf("n: %d\n", n);
        abort_on_error(n == -1, "fread() error");
        abort_on_error(sendto(sockfd, (struct pkt *) &packet, sizeof(packet), 0, (struct sockaddr *) &servaddr, sizeof(servaddr)) == -1,
                        "sendto() data error");
        count = count + n;
        memset(packet.data, 0, sizeof(packet.data));
    }
    printf("Tot Bytes sent: %d\n", count);

    memset(packet.data, 0, sizeof(packet.data));
    memcpy(packet.data, END_FLAG, strlen(END_FLAG));
    abort_on_error(sendto(sockfd, (struct pkt *) &packet, sizeof(packet), 0, (struct sockaddr *) &servaddr, sizeof(servaddr)) == -1,
                    "sendto() end_flag error");

    fclose(file);
    return 0;
}

server.c

代码语言:javascript
复制
#include <stdio.h>
#include <stdlib.h>
#include <unistd.h>
#include <string.h>
#include <fcntl.h>
#include <arpa/inet.h>
#include <sys/socket.h>

#include "macro.h"

void run(int sockfd, struct sockaddr *cliaddr, socklen_t clilen)
{
    int n = 0, count = 0, status = 0;
    socklen_t len;
    // char buf[MAXLINE];
    FILE *file;
    PACK packet;

    len = clilen;
    n = recvfrom(sockfd, &packet, sizeof(packet), 0, cliaddr, &len);
    abort_on_error(n == -1, "recvfrom() filename error");
    // buf[n] = 0;
    printf("Received from client: [%s]\n", packet.data);

    file = fopen((const char *) packet.data, "w+");
    abort_on_error(file == NULL, "fopen() error");

    packet.seq_num = 0;
    packet.status = 0;
    memset(packet.data, 0, sizeof(packet.data));
    memcpy(packet.data, "ok", strlen("ok"));
    abort_on_error(sendto(sockfd, (struct pkt *) &packet, sizeof(packet), 0, cliaddr, len) == -1,
                    "sendto() ok error");

    memset(packet.data, 0, sizeof(packet.data));
    abort_on_error(recvfrom(sockfd, &packet, sizeof(packet), 0, cliaddr, &len) == -1,
                    "recvfrom() error");
    long filesize = strtol((const char *) packet.data, NULL, 0);
    printf("filesize: %ld\n", filesize);

    while ((n = recvfrom(sockfd, &packet, sizeof(packet), 0, cliaddr, &len))) {
        abort_on_error(n == -1, "recvfrom() data error");
        // packet.data[n] = '\0';
        // printf("%s\n", packet.data);
        if (!(strcmp((const char *) packet.data, END_FLAG))) {
            break;
        }

        int num_packet = filesize / n;
        // printf("num_packet: %d\n", num_packet);

        count += n;
        if(!num_packet){
            fwrite(packet.data, sizeof(char), n-(n-filesize), file);
            printf("byte to write: %ld\n", n-(n-filesize));
        }
        else {
            if(count <= filesize) {
                fwrite(packet.data, sizeof(char), n-8, file);
                printf("byte to write: %d\n", n);
            }
            else if ((count > filesize) && (filesize-num_packet*n-8) && !status) {
                    fwrite(packet.data, sizeof(char), filesize-num_packet*(n-8), file);
                    printf("byte to write: %ld\n", filesize-num_packet*(n-8));
                    status = 1;
            }
        }
    }
    printf("Tot Bytes received: %d\n", count);
    fclose(file);
}

int main(int argc, char **argv)
{
    int sockfd;
    struct sockaddr_in servaddr, cliaddr;

    sockfd = socket(AF_INET, SOCK_DGRAM, 0);
    bzero(&servaddr, sizeof(servaddr));
    servaddr.sin_family = AF_INET;
    servaddr.sin_addr.s_addr = htonl(INADDR_ANY);
    servaddr.sin_port = htons(SERV_PORT);

    bind(sockfd, (struct sockaddr *) &servaddr, sizeof(servaddr));

    run(sockfd, (struct sockaddr *) &cliaddr, sizeof(cliaddr));

    return 0;
}

对于小于1400字节的文件,它可以完美地工作!如果文件大于1400字节(发送的数据包更多),则会添加一些垃圾字节。我找不到原因!

EN

回答 1

Stack Overflow用户

发布于 2017-12-07 17:36:59

字符串末尾的垃圾字节是对缺少字符串nul终止问题的完全暴露。

这里:

代码语言:javascript
复制
memcpy(packet.data, target, strlen(target));

或者在这里:

代码语言:javascript
复制
memcpy(packet.data, "ok", strlen("ok"));

您正在复制没有终止符的字符串。

现在,在接收时,您无法知道字符串的结束位置,fprintf也是如此。

因此,在复制字符串时,请使用strcpy而不是memcpy。它将正常工作并添加nul终止字符

代码语言:javascript
复制
strcpy(packet.data, target);

代码语言:javascript
复制
strcpy(packet.data, "ok");
票数 1
EN
页面原文内容由Stack Overflow提供。腾讯云小微IT领域专用引擎提供翻译支持
原文链接:

https://stackoverflow.com/questions/47691432

复制
相关文章

相似问题

领券
问题归档专栏文章快讯文章归档关键词归档开发者手册归档开发者手册 Section 归档