我正在尝试使用枚举来总结System.Net.Mail.SmtpClient.Send
的结果。这是为了让我知道我是否应该重试发送电子邮件,并希望防止重复发送电子邮件。
public enum MailSendStatus {
None,
Sent,
ErrorCannotSend,
TryAgain,
SentMaybe
}
我捕获了Send
中的所有异常,并将SmtpException.StatusCode
从http://msdn.microsoft.com/en-us/library/system.net.mail.smtpstatuscode(v=vs.80).aspx中分离出来。故障看起来对吗?或者有更好的方法来做这件事?
try {
smtp.Send(msg);
} catch (ArgumentNullException e) {
return MailSendStatus.ErrorCannotSend;
} catch (ObjectDisposedException e) {
return MailSendStatus.ErrorCannotSend;
} catch (InvalidOperationException e) {
return MailSendStatus.ErrorCannotSend;
} catch (SmtpFailedRecipientsException e) {
return MailSendStatus.ErrorCannotSend;
} catch (SmtpException e) {
switch(e.StatusCode) {
case SmtpStatusCode.BadCommandSequence:
case SmtpStatusCode.MailboxNameNotAllowed:
case SmtpStatusCode.HelpMessage:
case SmtpStatusCode.SyntaxError:
case SmtpStatusCode.SystemStatus:
return MailSendStatus.ErrorCannotSend;
case SmtpStatusCode.CannotVerifyUserWillAttemptDelivery:
case SmtpStatusCode.UserNotLocalWillForward:
return MailSendStatus.SentMaybe;
case SmtpStatusCode.ClientNotPermitted:
case SmtpStatusCode.CommandNotImplemented:
case SmtpStatusCode.CommandParameterNotImplemented:
case SmtpStatusCode.CommandUnrecognized:
case SmtpStatusCode.ExceededStorageAllocation:
case SmtpStatusCode.GeneralFailure:
case SmtpStatusCode.InsufficientStorage:
case SmtpStatusCode.LocalErrorInProcessing:
case SmtpStatusCode.MailboxBusy:
case SmtpStatusCode.MailboxUnavailable:
case SmtpStatusCode.MustIssueStartTlsFirst:
case SmtpStatusCode.ServiceClosingTransmissionChannel:
case SmtpStatusCode.ServiceNotAvailable:
case SmtpStatusCode.ServiceReady:
case SmtpStatusCode.StartMailInput:
case SmtpStatusCode.TransactionFailed:
case SmtpStatusCode.UserNotLocalTryAlternatePath:
return MailSendStatus.TryAgain;
case SmtpStatusCode.Ok:
break;
}
} catch (Exception e) {
return MailSendStatus.SentMaybe;
}
return MailSendStatus.Sent;
发布于 2011-04-14 13:39:06
catch (ArgumentNullException e) { return MailSendStatus.ErrorCannotSend;} catch
(ObjectDisposedException e) { return MailSendStatus.ErrorCannotSend;} catch
(InvalidOperationException e) { return MailSendStatus.ErrorCannotSend;
我不喜欢这样。ArgumentNull、ObjectDisposed是编程错误(InvalidOperation也是)。您不应将它们分解为SMTP错误,而应将其修复。Fpr这样,使程序崩溃是很好的(并发出堆栈跟踪)。方法“快速失败”。不要重复你不知道如何处理的异常,InvalidOperationException,ObjectDisposedException表示状态有问题,ArbumentNullException是用法/ ui错误。
https://stackoverflow.com/questions/5658980
复制相似问题