blocks|key|3681790|text|是的，这个类型当然代表了一个奇特的链表结构，因为它有一个数据槽和一个下一个指针。|type|unstyled|depth|inlineStyleRanges|entityRanges|data|3681791|不过，我要更改的一件事是insert方法。我的意思是，这个方法接受数据类型会更方便，在本例中是int，让LinkedList类承担分配数据结构的工作。|offset|length|style|CODE|3681792|例如。|3681793|void+insert(int+data)+{
++++while(this->next+!=+0)++
++++this+=+this->next;++

++++this->next+=+new+LinkedListNode(data);++
}|code-block|syntax|javascript|3681794|entityMap^0|0|C|6|1B|3|1G|A|0|0|0^^$0|@$1|2|3|4|5|6|7|Q|8|@]|9|@]|A|$]]|$1|B|3|C|5|6|7|R|8|@$D|S|E|T|F|G]|$D|U|E|V|F|G]|$D|W|E|X|F|G]]|9|@]|A|$]]|$1|H|3|I|5|6|7|Y|8|@]|9|@]|A|$]]|$1|J|3|K|5|L|7|Z|8|@]|9|@]|A|$M|N]]|$1|O|3|-4|5|6|7|10|8|@]|9|@]|A|$]]]|P|$]]

Yes this type certainly represents a singularly linked list structure as it has a data slot and a next pointer. 

One thing I would change though is the <code>insert</code> method. IMHO, it's more convenient for this method to take the data type, in this case <code>int</code>, and let the <code>LinkedList</code> class take on the work of allocating the data structure. 

For example. 

<pre><code>void insert(int data) {
 while(this-&gt;next != 0) 
 this = this-&gt;next; 

 this-&gt;next = new LinkedListNode(data); 
}
</code></pre>

blocks|key|3681815|text|type|unstyled|depth|inlineStyleRanges|entityRanges|data|3681816|你的课还没结束。在最后添加一个};。|ordered-list-item|offset|length|style|CODE|3681817|应该关闭构造函数的大括号是一个开始的。|3681818|这是一个链表，但使用单独的node和list类会更简单，因为在你的例子中，内存管理完全由用户负责，这使得使用这个类很痛苦。|3681819|3681820|entityMap^0|0|F|2|0|0|D|4|I|4|0|0^^$0|@$1|2|3|-4|4|5|6|O|7|@]|8|@]|9|$]]|$1|A|3|B|4|C|6|P|7|@$D|Q|E|R|F|G]]|8|@]|9|$]]|$1|H|3|I|4|C|6|S|7|@]|8|@]|9|$]]|$1|J|3|K|4|C|6|T|7|@$D|U|E|V|F|G]|$D|W|E|X|F|G]]|8|@]|9|$]]|$1|L|3|-4|4|5|6|Y|7|@]|8|@]|9|$]]|$1|M|3|-4|4|5|6|Z|7|@]|8|@]|9|$]]]|N|$]]

<ol>
<li>Your class is not closed. Add a <code>};</code> at the very end.</li>
<li>The brace that is supposed to be closing the constructor is an opening one.</li>
<li>This is a linked list alright, but it's simpler to use a separate <code>node</code> and <code>list</code> classes since in your case memory management falls completely to the user, making usage of this class a pain.</li>
</ol>

blocks|key|3681830|text|您也将最后一个节点的下一个节点指向NULL|type|unstyled|depth|inlineStyleRanges|entityRanges|data|3681831|无效插入(LinkedList*节点)|3681832|{|3681833|+while(this->next+!=+0)|code-block|syntax|javascript|3681834|+this+=+this->next;++|3681835|this->next+=+node;+
node->next+=+0;|3681836|}|3681837|entityMap^0|0|0|0|0|0|0|0^^$0|@$1|2|3|4|5|6|7|S|8|@]|9|@]|A|$]]|$1|B|3|C|5|6|7|T|8|@]|9|@]|A|$]]|$1|D|3|E|5|6|7|U|8|@]|9|@]|A|$]]|$1|F|3|G|5|H|7|V|8|@]|9|@]|A|$I|J]]|$1|K|3|L|5|H|7|W|8|@]|9|@]|A|$I|J]]|$1|M|3|N|5|H|7|X|8|@]|9|@]|A|$I|J]]|$1|O|3|P|5|6|7|Y|8|@]|9|@]|A|$]]|$1|Q|3|-4|5|6|7|Z|8|@]|9|@]|A|$]]]|R|$]]

You have point the last node's next to NULL as well 

void insert(LinkedList *node) 
 { 
 while(this->next != 0) 
 this = this->next; 

<pre><code>this-&gt;next = node; 
node-&gt;next = 0;
</code></pre>

}

blocks|key|1365625|text|如果需要链表，请使用链表的STL版本。它已经被实现和测试了，在大多数情况下，大多数人都不会实现比它更好的东西。|type|unstyled|depth|inlineStyleRanges|entityRanges|data|1365626|从代码的角度来看，您不能赋值给this，因此insert方法将不会被编译--在这里考虑使用尾递归。在稍高一点的级别上，你应该更喜欢初始化列表而不是构造函数体中的赋值。您可以考虑使用智能指针来减轻手动管理内存的需要，即使在这种简单的情况下这不是问题。|offset|length|style|CODE|1365627|您应该始终首先考虑接口，然后再考虑如何为其提供实现。特别是，您可能需要的最简单的接口是：|1365628|class+List+{
public:
  List();   ++++++++++++++++// creates an empty list

  void+append(+int+value+);+//+adds+a+new+element+at+the+tail+of+the+list
+++++//+push_front(+value+)+in+STL+sequence+containers

++void+insert(+int+value+);+//+inserts+a+new+element+before+the+head+of+the+list
+++++//+push_back(+value+)+in+STL+sequence+containers

++//+some+way+of+iterating+(I+like+STL+iterators,
++//+but+Java+style+iterator+--even+if+worse--+could+suffice)
};|code-block|syntax|javascript|1365629|事实上，我希望在接口中有更多的东西，但上面的设置是一个最小的方法(其中不包括析构函数，但我当然希望通过实现来管理资源！)。现在，使用您对LinkedList的定义(实际上更接近于节点的定义)，您不能创建空列表。您可以在列表的末尾插入append，但不能在列表的第一个元素之前插入。您没有提供从列表中提取数据的工具(!!)|1365630|如果您花了几分钟时间思考您可能想要从链表中获得的额外特性(通过迭代器删除给定的元素，以便您可以搜索值X并将其从列表中删除，在列表中的给定位置插入，而不仅仅是头或尾...)您将在接口中提出其他需求，然后您只需要在代码中满足这些需求，这通常要简单得多:)|1365631|entityMap^0|0|F|4|M|6|0|0|0|1W|A|38|6|0|0^^$0|@$1|2|3|4|5|6|7|U|8|@]|9|@]|A|$]]|$1|B|3|C|5|6|7|V|8|@$D|W|E|X|F|G]|$D|Y|E|Z|F|G]]|9|@]|A|$]]|$1|H|3|I|5|6|7|10|8|@]|9|@]|A|$]]|$1|J|3|K|5|L|7|11|8|@]|9|@]|A|$M|N]]|$1|O|3|P|5|6|7|12|8|@$D|13|E|14|F|G]|$D|15|E|16|F|G]]|9|@]|A|$]]|$1|Q|3|R|5|6|7|17|8|@]|9|@]|A|$]]|$1|S|3|-4|5|6|7|18|8|@]|9|@]|A|$]]]|T|$]]

If you need a linked list use the STL version of it. It is already implemented and tested, and in most cases most people won't manage to implement anything better than that.

From the code point of view, you cannot assign to <code>this</code>, so the <code>insert</code> method will not compile --consider using tail recursion here. At a lightly higher level, you should prefer initialization lists to assignment in the body of constructors. You can consider using smart pointers to alleviate the need to manually manage memory, even if in this simple case it would not be a problem.

You should always think first on the interface and then on how you can provide an implementation for it. In particular the simplest interface you may want would be:

<pre><code>class List {
public:
  List();    // creates an empty list

  void append( int value ); // adds a new element at the tail of the list
 // push_front( value ) in STL sequence containers

 void insert( int value ); // inserts a new element before the head of the list
 // push_back( value ) in STL sequence containers

 // some way of iterating (I like STL iterators,
 // but Java style iterator --even if worse-- could suffice)
};
</code></pre>

In fact I would like more things in the interface, but the set above is a minimal approach (where the destructor is not included, but of course I want the resources to be managed by the implementation!). Now, with your definition of <code>LinkedList</code> (which is in fact closer to the definition of a node) you cannot create empty lists. You can <code>append</code> at the end of the list, but you cannot insert before the first element of the list. You did not offer a facility to extract data from the list (!!)

If you take a couple of minutes to think on the extra features you may want from a linked list (removal of a given element through an iterator so you can search for value X and remove it from the list, insertion at a given position in the list, not just head or tail...) you will come up with other requirements in the interface, and then you only need to fulfill those requirements in code, which is always much simpler :)

blocks|key|5149628|text|在哪里定义成员'next‘？|type|unstyled|depth|inlineStyleRanges|entityRanges|data|5149629|您的insert()使用了'this->next'，但只有成员'data‘和'ptr’。|5149630|entityMap^0|0|0^^$0|@$1|2|3|4|5|6|7|F|8|@]|9|@]|A|$]]|$1|B|3|C|5|6|7|G|8|@]|9|@]|A|$]]|$1|D|3|-4|5|6|7|H|8|@]|9|@]|A|$]]]|E|$]]

Where is member 'next' defined?

Your insert() uses 'this->next',
but there are only members 'data' and 'ptr'.

blocks|key|1365708|text|我的问题是，您没有将列表与列表的节点区分开来。|type|unstyled|depth|inlineStyleRanges|entityRanges|data|1365709|这会导致这样的问题:如果没有空指针，就不能有一个空的列表：|1365710|我将创建一个头节点，如head+=+|1365711|+LinkedList(4)|blockquote|1365712|1365713|1365714|1365715|，这样我就会有一个链接表类(不需要动态分配)|unordered-list-item|1365716|我会有一个节点类(内部)来保存数据和指向下一个|1365717|的指针我会更新接口以获取数据对象(就像描述的Jared+Par一样)。|1365718|代码：|1365719|class+LinkedList
{
++++struct+Node
++++{
+++++++++Node(int+d):+data(d)+{next+=+NULL;}
++++++++~Node()+++++++++++++++{delete+next;}
++++++++int+++++++++++++++++++data;
++++++++Node*+++++++++++++++++next;
++++};

++++std::auto_ptr<Node>+++head;

++++Insert(int+data)
++++{
++++++++if+(head.get()+==+NULL)
++++++++{
++++++++++++head.reset(new+Node(data));
++++++++}
++++++++else
++++++++{
++++++++++++Node*+loop;
++++++++++++for(loop+=+head.get();loop->next+!=+NULL;loop+=+loop->next)+{};
++++++++++++loop->next+=+new+Node(data);
++++++++}
++++}
};

LinkedList+++list;|code-block|syntax|javascript|1365720|entityMap^0|0|0|0|0|0|0|0|0|0|0|0|0^^$0|@$1|2|3|4|5|6|7|11|8|@]|9|@]|A|$]]|$1|B|3|C|5|6|7|12|8|@]|9|@]|A|$]]|$1|D|3|E|5|6|7|13|8|@]|9|@]|A|$]]|$1|F|3|G|5|H|7|14|8|@]|9|@]|A|$]]|$1|I|3|-4|5|6|7|15|8|@]|9|@]|A|$]]|$1|J|3|-4|5|6|7|16|8|@]|9|@]|A|$]]|$1|K|3|-4|5|6|7|17|8|@]|9|@]|A|$]]|$1|L|3|M|5|N|7|18|8|@]|9|@]|A|$]]|$1|O|3|P|5|N|7|19|8|@]|9|@]|A|$]]|$1|Q|3|R|5|6|7|1A|8|@]|9|@]|A|$]]|$1|S|3|T|5|6|7|1B|8|@]|9|@]|A|$]]|$1|U|3|V|5|W|7|1C|8|@]|9|@]|A|$X|Y]]|$1|Z|3|-4|5|6|7|1D|8|@]|9|@]|A|$]]]|10|$]]

My problem is that you have not deferentiated the list from the nodes of the list. 
This causes the problem that you can not have an empty list without having a NULL pointer:

<blockquote>
 I will be creating a head node like head = new LinkedList(4)
</blockquote>

<ul>
<li>So I would have a linked list class (that does not need to be dynamically allocated)</li>
<li>I would have a node class (internal) that holds data and pointer to next</li>
<li>I would update the interface to take the data object (like Jared Par described).</li>
</ul>

Code:

<pre><code>class LinkedList
{
 struct Node
 {
 Node(int d): data(d) {next = NULL;}
 ~Node() {delete next;}
 int data;
 Node* next;
 };

 std::auto_ptr&lt;Node&gt; head;

 Insert(int data)
 {
 if (head.get() == NULL)
 {
 head.reset(new Node(data));
 }
 else
 {
 Node* loop;
 for(loop = head.get();loop-&gt;next != NULL;loop = loop-&gt;next) {};
 loop-&gt;next = new Node(data);
 }
 }
};

LinkedList list;
</code></pre>

<pre><code>class LinkedList
{
 private:
 int data; 
 LinkedList *ptr; 
public:
 LinkedList(int i_data) 
 { 
 data = i_data; 
 ptr = 0; 
 } 
 ~LinkedList() 
 { 
 delete ptr ; 
 } 
 void insert(LinkedList *node) 
 { 
 while(this-&gt;ptr!= 0) 
 this = this-&gt;ptr; 

 this-&gt;ptr= node; 
 } 
}
</code></pre>

I will be creating a head node like <code>head = new LinkedList(4)</code> and then will be calling like
<code>head-&gt;insert(new LinkedList(5))</code> and subsequently . Can you please tell me does above class represent a linkedlist . i think yes it has node which contain address of next node . Please correct me if i am wrong

What is the problem with my LinkedList class?

翻译质量差，导致语言生硬或混乱。

没有提供实际的解决方法或示例。

解答不清晰，无法理解或解决问题。

页面排版不美观，阅读体验差。

文章

问答

视频

学习中心

腾讯云实验室

直播

竞赛

腾讯云代码分析专区

腾讯iOA零信任安全管理系统专区

腾讯云架构师技术同盟交流圈

腾讯云数据库专区

腾讯云顾问专区

腾讯云原生专区

腾讯混元专区

腾讯云TCE专区

腾讯云Lighthouse专区

腾讯云HAI专区

腾讯云Edgeone专区

腾讯云存储专区

腾讯云智能专区

腾讯轻联专区 

腾讯云开发专区

TAPD专区

腾讯轻量云游戏服专区

腾讯云最具价值专家

腾讯云架构师技术同盟

腾讯云创作之星

腾讯云开发者先锋

腾讯云代码助手

云原生构建

TAPD 敏捷项目管理

Cloud Studio

SDK中心

API中心

命令行工具

涵盖代码开发、场景应用、自动测试全流程，助你从零构建专属AI助手

一站式MCP教程库，解锁AI应用新玩法

class LinkedList{  private:    int data;      LinkedList *ptr;  public:  LinkedList(int i_data)    {     data = i_data;      ptr = 0;    }    ~LinkedList()    {...

问我的LinkedList类有什么问题？
EN

Stack Overflow用户

社区

活动

圈层

关于

腾讯云开发者

热门产品

热门推荐

更多推荐

问我的LinkedList类有什么问题？EN