blocks|key|803327|text|这应该很简单。|type|unstyled|depth|inlineStyleRanges|entityRanges|data|803328|if+(errorNumbers.Length+==+6)
{
++++string+errNo+=+errorNumbers.Substring(0,+4);

++++switch+(errNo)
++++{
++++++++case+"1101":
++++++++case+"2121":
++++++++++++retStr+=+"AutoRepickAfterPickError";
++++++++++++break;
++++++++case+"1301":
++++++++case+"2321":
++++++++++++retStr+=+"AutoRepickAfterLAlignError";
++++++++++++break;
++++++++case+"1401":
++++++++case+"2221":
++++++++++++retStr+=+"AutoRepickAfterCAlignError";
++++++++++++break;
++++++++case+"1501":
++++++++case+"2041":
++++++++++++retStr+=+"AutoRepicksAfterManualRecovery";
++++++++++++break;
++++}
}|code-block|syntax|javascript|803329|还要注意，与Java语言不同，在C#中可以用==比较字符串。|offset|length|style|CODE|803330|"123"+==+"456"和"123".Equals("456")做同样的事情。|803331|entityMap^0|0|0|M|2|0|0|E|F|J|0^^$0|@$1|2|3|4|5|6|7|Q|8|@]|9|@]|A|$]]|$1|B|3|C|5|D|7|R|8|@]|9|@]|A|$E|F]]|$1|G|3|H|5|6|7|S|8|@$I|T|J|U|K|L]]|9|@]|A|$]]|$1|M|3|N|5|6|7|V|8|@$I|W|J|X|K|L]|$I|Y|J|Z|K|L]]|9|@]|A|$]]|$1|O|3|-4|5|6|7|10|8|@]|9|@]|A|$]]]|P|$]]

That should be pretty straightforward

<pre><code>if (errorNumbers.Length == 6)
{
 string errNo = errorNumbers.Substring(0, 4);

 switch (errNo)
 {
 case "1101":
 case "2121":
 retStr = "AutoRepickAfterPickError";
 break;
 case "1301":
 case "2321":
 retStr = "AutoRepickAfterLAlignError";
 break;
 case "1401":
 case "2221":
 retStr = "AutoRepickAfterCAlignError";
 break;
 case "1501":
 case "2041":
 retStr = "AutoRepicksAfterManualRecovery";
 break;
 }
}
</code></pre>

Also note that unlike in Java, in C# you can compare strings with <code>==</code>.

<code>"123" == "456"</code> does the same thing as <code>"123".Equals("456")</code>.

blocks|key|4497157|text|首先，在长if/else之前将errorNumbers.Substring(0,4)存储在一个局部变量中。|type|unstyled|depth|inlineStyleRanges|offset|length|style|CODE|entityRanges|data|4497158|然后，您可以使用从预期错误号到适当返回字符串的映射/字典来消除整个if/else。|4497159|entityMap^0|F|R|0|0^^$0|@$1|2|3|4|5|6|7|J|8|@$9|K|A|L|B|C]]|D|@]|E|$]]|$1|F|3|G|5|6|7|M|8|@]|D|@]|E|$]]|$1|H|3|-4|5|6|7|N|8|@]|D|@]|E|$]]]|I|$]]

First, store <code>errorNumbers.Substring(0,4)</code> in a local variable before the long if/else.

Then, you can eliminate the whole if/else using a map / dictionary from the expected error numbers to the appropriate return strings.

blocks|key|2421281|text|我会将错误代码映射到字典中，如下所示：|type|unstyled|depth|inlineStyleRanges|entityRanges|data|2421282|string+errorCode+=+errorNumbers.Substring(0,+4);
Dictionary<string,+string>+map+=+new+Dictionary<string,string>();
map.Add("1501",+"AutoRepicksAfterManualRecovery");
map.Add("2041",+"AutoRepicksAfterManualRecovery");
map.Add("1401",+"AutoRepickAfterCAlignError");
map.Add("2221",+"AutoRepickAfterCAlignError");
map.Add("1301",+"AutoRepickAfterPickError");
map.Add("2121",+"AutoRepickAfterPickError");
//+etc

if(!map.ContainsKey(errorCode))
+throw+new+Exception("Invalid+error+code");

return+map[errorCode];|code-block|syntax|javascript|2421283|entityMap^0|0|0^^$0|@$1|2|3|4|5|6|7|I|8|@]|9|@]|A|$]]|$1|B|3|C|5|D|7|J|8|@]|9|@]|A|$E|F]]|$1|G|3|-4|5|6|7|K|8|@]|9|@]|A|$]]]|H|$]]

I´d map the error codes in a dictionary like this:

<pre><code>string errorCode = errorNumbers.Substring(0, 4);
Dictionary&lt;string, string&gt; map = new Dictionary&lt;string,string&gt;();
map.Add("1501", "AutoRepicksAfterManualRecovery");
map.Add("2041", "AutoRepicksAfterManualRecovery");
map.Add("1401", "AutoRepickAfterCAlignError");
map.Add("2221", "AutoRepickAfterCAlignError");
map.Add("1301", "AutoRepickAfterPickError");
map.Add("2121", "AutoRepickAfterPickError");
// etc

if(!map.ContainsKey(errorCode))
 throw new Exception("Invalid error code");

return map[errorCode];
</code></pre>

blocks|key|803417|text|Select-Case怎么办？:D|type|unstyled|depth|inlineStyleRanges|entityRanges|data|803418|errorNumber+=+errorNumbers.Substring(0,4)
Select+Case+errorNumber+
+++Case+1101,2121
++++++retStr+=+"AutoRepickAfterPickError";
+++Case+1301,2321
++++++retStr+=+"AutoRepickAfterLAlignError";
+++...
End+Select|code-block|syntax|javascript|803419|entityMap^0|0|0^^$0|@$1|2|3|4|5|6|7|I|8|@]|9|@]|A|$]]|$1|B|3|C|5|D|7|J|8|@]|9|@]|A|$E|F]]|$1|G|3|-4|5|6|7|K|8|@]|9|@]|A|$]]]|H|$]]

What about Select-Case? :D

<pre><code>errorNumber = errorNumbers.Substring(0,4)
Select Case errorNumber 
 Case 1101,2121
 retStr = "AutoRepickAfterPickError";
 Case 1301,2321
 retStr = "AutoRepickAfterLAlignError";
 ...
End Select
</code></pre>

blocks|key|803447|text|首先，DRY+Principle+-+Don't+Repeat+Yourself。将errorNumbers.Substring(0,+4)的结果赋给一个局部变量：|type|unstyled|depth|inlineStyleRanges|offset|length|style|CODE|entityRanges|data|803448|string+subNumbers+=+errorNumbers.SubString(0,+4);
if+(subNumbers+==+"1401")+//+...|code-block|syntax|javascript|803449|对特定值情况(非范围)的支持：|BOLD|803450|可以将switch语句与字符串一起使用：|803451|switch(subNumbers)
{
++++case+"1401":
++++case+"2221":
++++++retStr+=+"AutoRepickAfterCAlignError";
++++++break;
++++case+"1501":
++++case+"2041":
++++++retStr+=+"AutoRepicksAfterManualRecovery";
++++++break;
++++//+etc
}|803452|switch语句的另一种选择是创建字典：|803453|var+selections+=+new+Dictionary<string,+string>()
{
++++{+"1401",+"AutoRepickAfterCAlignError"+},
++++{+"2221",+"AutoRepickAfterCAlignError"+},
++++{+"1501",+"AutoRepicksAfterManualRecovery"+},
++++{+"2041",+"AutoRepicksAfterManualRecovery"+},
++++//+etc
};

if+(selections.ContainsKey(subNumbers))
++++retStr+=+selections[subNumbers];|803454|范围：|803455|但是，如果您需要支持范围，则基本上必须坚持使用if/else块。还有其他选择，但是如果您的代码中只有这么多这样类型的if/else块，那么它们往往过于复杂。|803456|entityMap|0|LINK|mutability|MUTABLE|url|http://en.wikipedia.org/wiki/Don%2527t_repeat_yourself^0|16|S|3|11|0|0|0|C|3|0|0|0|0|0|0|3|0|N|2|Q|4|1M|2|1P|4|0^^$0|@$1|2|3|4|5|6|7|17|8|@$9|18|A|19|B|C]]|D|@$9|1A|A|1B|1|1C]]|E|$]]|$1|F|3|G|5|H|7|1D|8|@]|D|@]|E|$I|J]]|$1|K|3|L|5|6|7|1E|8|@$9|1F|A|1G|B|M]]|D|@]|E|$]]|$1|N|3|O|5|6|7|1H|8|@]|D|@]|E|$]]|$1|P|3|Q|5|H|7|1I|8|@]|D|@]|E|$I|J]]|$1|R|3|S|5|6|7|1J|8|@]|D|@]|E|$]]|$1|T|3|U|5|H|7|1K|8|@]|D|@]|E|$I|J]]|$1|V|3|W|5|6|7|1L|8|@$9|1M|A|1N|B|M]]|D|@]|E|$]]|$1|X|3|Y|5|6|7|1O|8|@$9|1P|A|1Q|B|C]|$9|1R|A|1S|B|C]|$9|1T|A|1U|B|C]|$9|1V|A|1W|B|C]]|D|@]|E|$]]|$1|Z|3|-4|5|6|7|1X|8|@]|D|@]|E|$]]]|10|$11|$5|12|13|14|E|$15|16]]]]

First off, <a href="http://en.wikipedia.org/wiki/Don%27t_repeat_yourself" rel="nofollow">DRY Principle - Don't Repeat Yourself</a>. Assign the result of <code>errorNumbers.Substring(0, 4)</code> to a local variable:

<pre><code>string subNumbers = errorNumbers.SubString(0, 4);
if (subNumbers == "1401") // ...
</code></pre>

Support for specific value cases (not ranges):

You can use a switch statement with strings:

<pre><code>switch(subNumbers)
{
 case "1401":
 case "2221":
 retStr = "AutoRepickAfterCAlignError";
 break;
 case "1501":
 case "2041":
 retStr = "AutoRepicksAfterManualRecovery";
 break;
 // etc
}
</code></pre>

An alternative to a switch statement is creating a dictionary:

<pre><code>var selections = new Dictionary&lt;string, string&gt;()
{
 { "1401", "AutoRepickAfterCAlignError" },
 { "2221", "AutoRepickAfterCAlignError" },
 { "1501", "AutoRepicksAfterManualRecovery" },
 { "2041", "AutoRepicksAfterManualRecovery" },
 // etc
};

if (selections.ContainsKey(subNumbers))
 retStr = selections[subNumbers];
</code></pre>

Ranges:

If you need to support ranges, you're basically going to have to stick with the <code>if</code>/<code>else</code> blocks, though. There are other options, but they tend to be too convoluted if you only have so many of these types of <code>if</code>/<code>else</code> blocks in your code.

blocks|key|4497318|text|你可以试试这个：|type|unstyled|depth|inlineStyleRanges|entityRanges|data|4497319|if+(errorNumbers.Length+==+6)
{

++++//Makes+it+easier+to+change+error+codes,+as+theyre+all+in+one+place
++++string[]+AutoRepickAfterPickError+=+{+"1101",+"2121"};
++++string[]+AutoRepickAfterLAlignError+=+{+"1301",+"2321"};
++++string[]+AutoRepickAfterCAlignError+=+{+"1401",+"2221"};
++++string[]+AutoRepicksAfterManualRecovery+=+{+"1501",+"2041"};
++++string+subString+=+errorNumbers.Substring(0,4);

++++++++if+(AutoRepickAfterPickError.Contains(subString));
++++++++{
++++++++++retStr+=+"AutoRepickAfterPickError";
++++++++}
++++++++else+if+(AutoRepickAfterLAlignError.Contains(subString))
++++++++{
++++++++++retStr+=+"AutoRepickAfterLAlignError";
++++++++}
++++++++else+if+(AutoRepickAfterCAlignError.Contains(subString))
++++++++{
++++++++++retStr+=+"AutoRepickAfterCAlignError";
++++++++}
++++++++else+if+(AutoRepicksAfterManualRecovery.Contains(subString))
++++++++{
++++++++++retStr+=+"AutoRepicksAfterManualRecovery";
++++++++}
}|code-block|syntax|javascript|4497320|entityMap^0|0|0^^$0|@$1|2|3|4|5|6|7|I|8|@]|9|@]|A|$]]|$1|B|3|C|5|D|7|J|8|@]|9|@]|A|$E|F]]|$1|G|3|-4|5|6|7|K|8|@]|9|@]|A|$]]]|H|$]]

You could try this:

<pre><code>if (errorNumbers.Length == 6)
{

 //Makes it easier to change error codes, as theyre all in one place
 string[] AutoRepickAfterPickError = { "1101", "2121"};
 string[] AutoRepickAfterLAlignError = { "1301", "2321"};
 string[] AutoRepickAfterCAlignError = { "1401", "2221"};
 string[] AutoRepicksAfterManualRecovery = { "1501", "2041"};
 string subString = errorNumbers.Substring(0,4);

 if (AutoRepickAfterPickError.Contains(subString));
 {
 retStr = "AutoRepickAfterPickError";
 }
 else if (AutoRepickAfterLAlignError.Contains(subString))
 {
 retStr = "AutoRepickAfterLAlignError";
 }
 else if (AutoRepickAfterCAlignError.Contains(subString))
 {
 retStr = "AutoRepickAfterCAlignError";
 }
 else if (AutoRepicksAfterManualRecovery.Contains(subString))
 {
 retStr = "AutoRepicksAfterManualRecovery";
 }
}
</code></pre>

blocks|key|2421457|text|应该使用errorCode和errorMessage之间的引用来初始化字典|type|unstyled|depth|inlineStyleRanges|entityRanges|data|2421458|Dictionary<int,+string>+errorsCache+=+new+Dictionary<int,+string>()
{
++{1101,"AutoRepickAfterPickError"},
++{2121,"AutoRepickAfterPickError"},
++{1401,"AutoRepickAfterCAlignError"},
++...
}|code-block|syntax|javascript|2421459|您可以定义GetErrorDescription方法|2421460|public+string+GetErrorDescription(string+errorNumbers)
{
++string+retStr;
++if+(errorNumbers.Length+==+6)
++{
++++int+errorCode;++
++++if(int.TryParse(errorNumbers.Substring(0,4),+out+errorCode))
++++{
++++++errorsCache.TryGetValue(errorCode,+out+retStr);
++++}
++}

++return+retString;
++//+or+you+can+return+empty+string+instead+of+null
++return+retString+??+"";
}|2421461|entityMap^0|0|0|0|0^^$0|@$1|2|3|4|5|6|7|M|8|@]|9|@]|A|$]]|$1|B|3|C|5|D|7|N|8|@]|9|@]|A|$E|F]]|$1|G|3|H|5|6|7|O|8|@]|9|@]|A|$]]|$1|I|3|J|5|D|7|P|8|@]|9|@]|A|$E|F]]|$1|K|3|-4|5|6|7|Q|8|@]|9|@]|A|$]]]|L|$]]

You should initialize a dictionary with refferencies betwen errorCode and errorMessage

<pre><code>Dictionary&lt;int, string&gt; errorsCache = new Dictionary&lt;int, string&gt;()
{
 {1101,"AutoRepickAfterPickError"},
 {2121,"AutoRepickAfterPickError"},
 {1401,"AutoRepickAfterCAlignError"},
 ...
}
</code></pre>

You can define GetErrorDescription method

<pre><code>public string GetErrorDescription(string errorNumbers)
{
 string retStr;
 if (errorNumbers.Length == 6)
 {
 int errorCode; 
 if(int.TryParse(errorNumbers.Substring(0,4), out errorCode))
 {
 errorsCache.TryGetValue(errorCode, out retStr);
 }
 }

 return retString;
 // or you can return empty string instead of null
 return retString ?? "";
}
</code></pre>

I have this really long if else code 

<pre><code> if (errorNumbers.Length == 6)
 {
 if (errorNumbers.Substring(0,4).Equals("1101") || errorNumbers.Substring(0,4).Equals("2121"))
 {
 retStr = "AutoRepickAfterPickError";
 }
 else if (errorNumbers.Substring(0, 4).Equals("1301") || errorNumbers.Substring(0, 4).Equals("2321"))
 {
 retStr = "AutoRepickAfterLAlignError";
 }
 else if (errorNumbers.Substring(0, 4).Equals("1401") || errorNumbers.Substring(0, 4).Equals("2221"))
 {
 retStr = "AutoRepickAfterCAlignError";
 }
 else if (errorNumbers.Substring(0, 4).Equals("1501") || errorNumbers.Substring(0, 4).Equals("2041"))
 {
 retStr = "AutoRepicksAfterManualRecovery";
 }
</code></pre>

etc.....

How I can rewrite it to something more nice .
Trying to learn here something new , and I am in .net 2.0.
Thanks for help.

Refactoring big if else code

翻译质量差，导致语言生硬或混乱。

没有提供实际的解决方法或示例。

解答不清晰，无法理解或解决问题。

页面排版不美观，阅读体验差。

文章

问答

视频

学习中心

腾讯云实验室

直播

竞赛

腾讯云代码分析专区

腾讯iOA零信任安全管理系统专区

腾讯云架构师技术同盟交流圈

腾讯云数据库专区

腾讯云顾问专区

腾讯云原生专区

腾讯混元专区

腾讯云TCE专区

腾讯云Lighthouse专区

腾讯云HAI专区

腾讯云Edgeone专区

腾讯云存储专区

腾讯云智能专区

腾讯轻联专区 

腾讯云开发专区

TAPD专区

腾讯轻量云游戏服专区

腾讯云最具价值专家

腾讯云架构师技术同盟

腾讯云创作之星

腾讯云开发者先锋

腾讯云代码助手

云原生构建

TAPD 敏捷项目管理

Cloud Studio

SDK中心

API中心

命令行工具

涵盖代码开发、场景应用、自动测试全流程，助你从零构建专属AI助手

一站式MCP教程库，解锁AI应用新玩法

我有很长的if else代码 if (errorNumbers.Length == 6)      {        if (errorNumbers.Substring(0,4).Equals("1101") || errorNumbers.Substring(0,4).Equals("2121"))        ...

问重构大的if else代码
EN

Stack Overflow用户

社区

活动

圈层

关于

腾讯云开发者

热门产品

热门推荐

更多推荐

问重构大的if else代码EN