Eclipse在下面的代码中给出了这个警告:
public int getTicket(int lotteryId, String player) {
try {
c = DriverManager.getConnection("jdbc:mysql://" + this.hostname + ":" + this.port + "/" + this.database, this.user, this.password);
int ticketNumber;
PreparedStatement p = c.prepareStatement(
"SELECT max(num_ticket) " +
"FROM loteria_tickets " +
"WHERE id_loteria = ?"
);
p.setInt(1, lotteryId);
ResultSet rs = p.executeQuery();
if (rs.next()) {
ticketNumber = rs.getInt(1);
} else {
ticketNumber = -1;
}
ticketNumber++;
p = c.prepareStatement(
"INSERT INTO loteria_tickets " +
"VALUES (?,?,?,?)");
p.setInt(1, lotteryId);
p.setInt(2, ticketNumber);
p.setString(3, player);
p.setDate(4, new java.sql.Date((new java.util.Date()).getTime()));
p.executeUpdate();
return ticketNumber;
} catch (Exception e) {
e.printStackTrace();
} finally {
if (c != null) {
try {
c.close();
} catch (SQLException e) {
e.printStackTrace();
}
}
return -1;
}
}我的代码出了什么问题?
发布于 2013-07-05 12:50:24
删除其中的return语句。最后一个块被认为是清除块,返回通常不会在其中。
发布于 2014-10-09 05:35:49
来自finally的return“覆盖”了进一步的异常抛出。
public class App {
public static void main(String[] args) {
System.err.println(f());
}
public static int f() {
try {
throw new RuntimeException();
} finally {
return 1;
}
}
}1
发布于 2014-12-11 17:39:02
通常,finally块永远不应该有return语句,因为它会覆盖其他return、-statements或Exceptions。
要进一步阅读和更详细地回答它的背景,请参阅问题
https://stackoverflow.com/questions/17481251
复制相似问题