我试图制作一个程序,它接受两个用户输入(x和y),检查间隔中的所有素数,然后如果可用的话只打印三个最大素数。到目前为止,我的代码检查从最大到最小的间隔内的所有素数。
我的代码:
#include <stdio.h>
#include <stdlib.h>
void inputXY(int *x, int *y) {
printf("Enter value of x: ");
scanf("%d", x);
printf("Enter value of y: ");
scanf("%d", y);
}
void swap(int*x, int*y){
int temp;
temp = *x;
*x=*y;
*y=temp;
}
int primechecker(int divisor,int dividend){
if(dividend==divisor) return 1;
else if(dividend%divisor==0) return 0;
else primeChecker(divisor+1,dividend);
}
void largestonly(int*counter, int*largest1, int*largest2, int*largest3){
int temp;
temp=*counter;
if (temp>*largest1&&*largest2) ///incomplete attempt
}
void printlargest(int *x, int *y, int*largest1, int*largest2, int*largest3){ ///I do not know if this would work, since I have not equated largest1, largest2, and largest3 to zeroes. My idea here is that, if any specific variables are empty, different specific lines should be printed.
if (*largest1==0&&(*largest2&&*largest3!=0)) {
printf("There are two prime numbers: ");
printf("%d, %d", *largest2, *largest3);
}
else if (*largest1&&*largest2==0&&*largest3!=0){
printf("There is only one prime number: ");
printf("%d", *largest3);
}
else if (*largest1&&*largest2&&largest3!=0){
printf("The three largest prime numbers between %d and %d are: ", *x, *y);
printf("%d, %d, %d", *largest1, *largest2, *largest3);
}
else if (*largest1&&*largest2&&largest3==0){
printf("No prime numbers found!");
}
}
int main(){
int x,y,largest1, largest2, largest3, counter, divisor, dividend, i;
divisor=2;
dividend=counter;
inputXY(&x, &y);
if ((x&&y==0),(x&&y==1)) printf("Invalid range!\n");
if (x>y) swap(&x, &y);
for (i=0; i<=3; i++){
for(counter=y;counter>=x;counter--) {
if (primechecker(divisor,counter)==1) largestonly(&counter, &largest1, &largest2, &largest3);
}
}
printlargest(&x, &y, &largest1, &largest2, &largest3);
return 0;
}
我还没有成功地编写一个可以对main()
中的for循环生成的所有整数进行排序的工作函数。正如上面所示,它是largestonly()
函数。与此相关,我的printlargest()
函数无疑不起作用。我在这里的想法是,如果largest1
不包含任何值(或等于0
或其他一些我无法想到的更合适的值),则该函数将只打印找到的两个最大素数。相对地,如果largest1
和largest2
都是空的,则只会打印最大的素数。如果所有变量都为空,则应打印"No prime numbers found!"
。我现在非常不知道该如何处理我的代码,所以任何类型的帮助都会受到极大的感谢。谢谢。
发布于 2022-04-21 12:55:35
这里有几件事要做。
首先,注意第21行,调用不存在的primeChecker()
函数。编译时会引发错误。
第二,你不需要“整理”任何东西。当质数到达时,您只需将它们存储到变量中。我注意到您认为largest3
是第一个需要填充的(至少可以从printlargest()
中理解),这给我们提供了以下内容:
void largestonly(int counter, int* largest1, int* largest2, int* largest3){
if(*largest3 == 0)
*largest3 = counter;
else if(*largest2 == 0)
*largest2 = counter;
else if(*largest1 == 0)
*largest1 = counter;
}
此外,不需要首先传递计数器的地址,因为您不需要修改它。
最后,在main()
函数中,不需要双循环。这样想吧。如果你要做精神上的练习,你会记下数字,检查它们是否是素数,并把它们写下来,如果它们满足条件:成为素数,成为第一,第二或第三。你不需要做三次。因此:
int main(){
int x,y;
inputXY(&x, &y);
int largest1 = 0;
int largest2 = 0;
int largest3 = 0;
int divisor = 2;
if ((x&&y==0),(x&&y==1)) printf("Invalid range!\n");
if (x>y) swap(&x, &y);
for(int counter=y;counter>=x;counter--) {
if (primechecker(divisor,counter)==1)
largestonly(counter, &largest1, &largest2, &largest3);
}
printlargest(&x, &y, &largest1, &largest2, &largest3);
return 0;
}
另外,在不初始化变量的情况下声明变量的方式有时也是危险的。在这种情况下,由于largest1
、largest2
和largest3
没有设置为0,您就没有机会触发任何printlargest()
案例。这可能是因为你被困在你的程序的一部分,你认为也会处理,但我仍然想指出它,以防万一。
编辑:您还可以在for
循环中添加一个条件,以便如果largest1
不等于0,则退出循环。这将防止程序循环(潜在)大量的数字,当你已经拥有你所需要的一切。如下所示(对于上下文,使用现有的for
循环):
for(int counter=y;counter>=x;counter--) {
if (primechecker(divisor,counter)==1)
largestonly(counter, &largest1, &largest2, &largest3);
if(largest1 != 0)
break;
}
希望这能澄清你所遇到的问题,如果有必要的话,你可以随便问点什么,或者指出我在你的问题中可能会误解的一些事情。
下面是完整的代码:
#include <stdio.h>
#include <stdlib.h>
void inputXY(int *x, int *y) {
printf("Enter value of x: ");
scanf("%d", x);
printf("Enter value of y: ");
scanf("%d", y);
}
void swap(int*x, int*y){
int temp;
temp = *x;
*x=*y;
*y=temp;
}
int primechecker(int divisor,int dividend){
if(dividend==divisor) return 1;
else if(dividend%divisor==0) return 0;
else primechecker(divisor+1,dividend);
}
void largestonly(int counter, int* largest1, int* largest2, int* largest3){
if(*largest3 == 0)
*largest3 = counter;
else if(*largest2 == 0)
*largest2 = counter;
else if(*largest1 == 0)
*largest1 = counter;
}
void printlargest(int *x, int *y, int*largest1, int*largest2, int*largest3){ ///I do not know if this would work, since I have not equated largest1, largest2, and largest3 to zeroes. My idea here is that, if any specific variables are empty, different specific lines should be printed.
if (*largest1==0&&(*largest2&&*largest3!=0)) {
printf("There are two prime numbers: ");
printf("%d, %d", *largest2, *largest3);
}
else if (*largest1&&*largest2==0&&*largest3!=0){
printf("There is only one prime number: ");
printf("%d", *largest3);
}
else if (*largest1&&*largest2&&largest3!=0){
printf("The three largest prime numbers between %d and %d are: ", *x, *y);
printf("%d, %d, %d", *largest1, *largest2, *largest3);
}
else if (*largest1&&*largest2&&largest3==0){
printf("No prime numbers found!");
}
}
int main(){
int x,y;
inputXY(&x, &y);
int largest1 = 0;
int largest2 = 0;
int largest3 = 0;
int divisor = 2;
if ((x&&y==0),(x&&y==1)) printf("Invalid range!\n");
if (x>y) swap(&x, &y);
for(int counter=y;counter>=x;counter--) {
if (primechecker(divisor,counter)==1)
largestonly(counter, &largest1, &largest2, &largest3);
}
printlargest(&x, &y, &largest1, &largest2, &largest3);
return 0;
}
https://stackoverflow.com/questions/71954139
复制相似问题