blocks|key|1958007|text|您的函数max_of_four不是返回最大值，而是打印一个数字并返回0。|type|unstyled|depth|inlineStyleRanges|offset|length|style|CODE|entityRanges|data|1958008|在某些数字相同的情况下，代码的逻辑也是错误的(您可能希望>=而不是>来处理这个问题)。|1958009|作为提示，如果有一个函数max(a,+b)返回两个数字的最大值，则可以找到四个数字的最大值：|1958010|int+max_of_four(int+a,+int+b,+int+c,+int+d)+{
++++return+max(max(a,+b),+max(c,+d));
}|code-block|syntax|javascript|1958011|这可能对你有帮助。|1958012|entityMap^0|4|B|0|S|2|X|1|0|C|9|0|0|0^^$0|@$1|2|3|4|5|6|7|S|8|@$9|T|A|U|B|C]]|D|@]|E|$]]|$1|F|3|G|5|6|7|V|8|@$9|W|A|X|B|C]|$9|Y|A|Z|B|C]]|D|@]|E|$]]|$1|H|3|I|5|6|7|10|8|@$9|11|A|12|B|C]]|D|@]|E|$]]|$1|J|3|K|5|L|7|13|8|@]|D|@]|E|$M|N]]|$1|O|3|P|5|6|7|14|8|@]|D|@]|E|$]]|$1|Q|3|-4|5|6|7|15|8|@]|D|@]|E|$]]]|R|$]]

Your function <code>max_of_four</code> is not returning the maximum number, it's printing out a number and returning 0.
The logic of your code is also wrong in the case when some of the numbers are the same (perhaps you want <code>&gt;=</code> rather than <code>&gt;</code> to handle this).
As a hint, if you have a function <code>max(a, b)</code> which returns the maximum of two numbers, you can find the maximum of four numbers:
<pre><code>int max_of_four(int a, int b, int c, int d) {
 return max(max(a, b), max(c, d));
}
</code></pre>
This may help you.

blocks|key|569821|text|Please+tell+me+what+I+am+doing+wrong+and+please+correct+it.|type|unstyled|depth|inlineStyleRanges|offset|length|style|CODE|entityRanges|data|569822|问题是，您试图编写过于复杂的复杂代码。|569823|下面是一个非常简单的函数重写(将4个值的最大值返回给调用者)。|569824|int+max_of_four(+int+a,+int+b,+int+c,+int+d+)+{
++++int+max+=+a;

++++if(+b+>+max+)+max+=+b;
++++if(+c+>+max+)+max+=+c;
++++if(+d+>+max+)+max+=+d;

++++return+max;
}|code-block|syntax|javascript|569825|保持简单，bug就很少有机会让你感到沮丧。|569826|entityMap^0|0|1N|0|0|0|0|0^^$0|@$1|2|3|4|5|6|7|S|8|@$9|T|A|U|B|C]]|D|@]|E|$]]|$1|F|3|G|5|6|7|V|8|@]|D|@]|E|$]]|$1|H|3|I|5|6|7|W|8|@]|D|@]|E|$]]|$1|J|3|K|5|L|7|X|8|@]|D|@]|E|$M|N]]|$1|O|3|P|5|6|7|Y|8|@]|D|@]|E|$]]|$1|Q|3|-4|5|6|7|Z|8|@]|D|@]|E|$]]]|R|$]]

<code>Please tell me what I am doing wrong and please correct it.</code>
What's gone wrong is that you've tried to write intricate code that is too complicated.
Here's a very simple re-write of your function (returning the maximum of the 4 values to the caller.)
<pre><code>int max_of_four( int a, int b, int c, int d ) {
 int max = a;

 if( b &gt; max ) max = b;
 if( c &gt; max ) max = c;
 if( d &gt; max ) max = d;

 return max;
}
</code></pre>
Keep things simple and bugs have fewer chances to make you frustrated.

blocks|key|568034|text|根据问题标题|type|unstyled|depth|inlineStyleRanges|entityRanges|data|568035|568036|编写一个函数int+max_of_four(int+a，int+b，int+c，int+d)，它读取四个参数并返回其中最大的参数。|blockquote|568037|568038|568039|函数必须返回最大值，但函数返回0。|568040|int+max_of_four(int+a,+int+b,+int+c,+int+d)
{
++++//...
++++return+0;
}|code-block|syntax|javascript|568041|此外，如果至少有两个参数具有最大值，则函数将不输出任何参数。|568042|例如，该函数可以通过以下方式查找。|568043|int+max_of_four(int+a,+int+b,+int+c,+int+d)
{
++++if+(+!(+a+<+b+)+&&+!(+a+<+c+)+&&+!(+a+<+d+)+)+
++++{
++++++++return+a;
++++}+
++++else+if+(+!(+b+<+c+)+&&+!(+b+<+d+)+)+
++++{
++++++++return+b;
++++}+
++++else+if+(+!(+c+<+d+)+)+
++++{
++++++++return+c;
++++}+
++++else+
++++{
+++++++return+d;
++++}
}|568044|entityMap^0|0|0|0|0|0|0|0|0|0|0^^$0|@$1|2|3|4|5|6|7|W|8|@]|9|@]|A|$]]|$1|B|3|-4|5|6|7|X|8|@]|9|@]|A|$]]|$1|C|3|D|5|E|7|Y|8|@]|9|@]|A|$]]|$1|F|3|-4|5|6|7|Z|8|@]|9|@]|A|$]]|$1|G|3|-4|5|6|7|10|8|@]|9|@]|A|$]]|$1|H|3|I|5|6|7|11|8|@]|9|@]|A|$]]|$1|J|3|K|5|L|7|12|8|@]|9|@]|A|$M|N]]|$1|O|3|P|5|6|7|13|8|@]|9|@]|A|$]]|$1|Q|3|R|5|6|7|14|8|@]|9|@]|A|$]]|$1|S|3|T|5|L|7|15|8|@]|9|@]|A|$M|N]]|$1|U|3|-4|5|6|7|16|8|@]|9|@]|A|$]]]|V|$]]

According to the question title
<blockquote>
Write a function int max_of_four(int a, int b, int c, int d) which
reads four arguments and returns the greatest of them
</blockquote>
the function must return the maximum value but your function returns 0.
<pre><code>int max_of_four(int a, int b, int c, int d)
{
 //...
 return 0;
}
</code></pre>
Moreover your function will output nothing if at least two arguments have the maximum value.
The function can look for example the following way.
<pre><code>int max_of_four(int a, int b, int c, int d)
{
 if ( !( a &lt; b ) &amp;&amp; !( a &lt; c ) &amp;&amp; !( a &lt; d ) ) 
 {
 return a;
 } 
 else if ( !( b &lt; c ) &amp;&amp; !( b &lt; d ) ) 
 {
 return b;
 } 
 else if ( !( c &lt; d ) ) 
 {
 return c;
 } 
 else 
 {
 return d;
 }
}
</code></pre>

blocks|key|1962125|text|据我所知，这里的第一个答案是最好的。但不幸的是我现在还不能投赞成票。|type|unstyled|depth|inlineStyleRanges|entityRanges|data|1962126|无论如何，如果要编写一个函数以返回四个数字中最大的数字，最好先声明一个变量来存储最大值，然后将其初始化为0(或者，也可以将其初始化为给定的第一个数字)。|1962127|int+max_of_four(int+a,+int+b,+int+c,+int+d)
{
++/*+
+++Edit+#1:+Assigning+the+first+value+(among+the+four+numbers)+to+
+++max+is+the+best+option.+Please+see+below+this+code-box+for+
+++explanation.+Thanks+for+pointing+my+mistake+out,+@Andrew+Henle!
++*/
++max+=+a;+//this+will+store+the+largest+value+eventually
++if(b+>+max)+//max+is+equal+to+"a"+right+now
++++max+=+b;+++
++/*+
++++if+b+is+greater+than+the+value+stored+in+max,+then+replace+max+with+b.
++++else,+leave+max+as+it+is+and+proceed+to+the+next+line+of+code.
++*/

++if(c+>+max)+//max+has+the+largest+number+among+a+&+b+right+now
++++max+=+c;
++if(d+>+max)+//max+has+the+largest+number+among+a,+b,+and+c
++++max+=+d;

++return(max);+//the+largest+value+among+a,b,c,d+will+be+returned
}|code-block|syntax|javascript|1962128|1962129|编辑:我最初假设只要求您为正整数编写代码。然而，正如Andrew+Henle所指出的，max+=+0不适用于负整数，因为负整数总是小于0。因此，max+=+a是进行操作的最佳方法。如果a被证明是最大的价值，那就太好了！如果没有，那么它最终将被其他更大的值所取代，max最终将存储最大的数字。谢谢你安德鲁！嘿，押韵！:)|blockquote|offset|length|style|BOLD|1962130|1962131|其他人已经指出了您的编码/逻辑错误，但是这里有一个要点：|1962132|1962133|不管您在函数中写了什么，函数都是返回0;|1962134|Your函数的|unordered-list-item|1962135|，在实际返回值时，返回|1962136|函数不必要地打印了一些数字。您实际上是将返回值赋值给另一个变量，和，对吗？|1962137|1962138|1962139|entityMap|0|LINK|mutability|MUTABLE|url|https://stackoverflow.com/users/4756299/andrew-henle^0|0|0|0|0|17|7|20|7|2K|1|3N|3|Q|C|0|0|0|0|0|0|0|9|2|0|0|11|0|0|0^^$0|@$1|2|3|4|5|6|7|1D|8|@]|9|@]|A|$]]|$1|B|3|C|5|6|7|1E|8|@]|9|@]|A|$]]|$1|D|3|E|5|F|7|1F|8|@]|9|@]|A|$G|H]]|$1|I|3|-4|5|6|7|1G|8|@]|9|@]|A|$]]|$1|J|3|K|5|L|7|1H|8|@$M|1I|N|1J|O|P]|$M|1K|N|1L|O|P]|$M|1M|N|1N|O|P]|$M|1O|N|1P|O|P]]|9|@$M|1Q|N|1R|1|1S]]|A|$]]|$1|Q|3|-4|5|6|7|1T|8|@]|9|@]|A|$]]|$1|R|3|S|5|6|7|1U|8|@]|9|@]|A|$]]|$1|T|3|-4|5|6|7|1V|8|@]|9|@]|A|$]]|$1|U|3|V|5|6|7|1W|8|@]|9|@]|A|$]]|$1|W|3|X|5|Y|7|1X|8|@]|9|@]|A|$]]|$1|Z|3|10|5|Y|7|1Y|8|@$M|1Z|N|20|O|P]]|9|@]|A|$]]|$1|11|3|12|5|Y|7|21|8|@$M|22|N|23|O|P]]|9|@]|A|$]]|$1|13|3|-4|5|6|7|24|8|@]|9|@]|A|$]]|$1|14|3|-4|5|6|7|25|8|@]|9|@]|A|$]]|$1|15|3|-4|5|6|7|26|8|@]|9|@]|A|$]]]|16|$17|$5|18|19|1A|A|$1B|1C]]]]

The first answer here is the best one, according to me. But unfortunately I can't upvote it just yet.
Anyway, if you are writing a function to return the largest number among four numbers, it's a good idea to first declare a variable to store the maximum value, and initialize it to 0 (alternatively, you can also initialize it to the first number given to you).
<pre><code>int max_of_four(int a, int b, int c, int d)
{
 /* 
 Edit #1: Assigning the first value (among the four numbers) to 
 max is the best option. Please see below this code-box for 
 explanation. Thanks for pointing my mistake out, @Andrew Henle!
 */
 max = a; //this will store the largest value eventually
 if(b &gt; max) //max is equal to &quot;a&quot; right now
 max = b; 
 /* 
 if b is greater than the value stored in max, then replace max with b.
 else, leave max as it is and proceed to the next line of code.
 */

 if(c &gt; max) //max has the largest number among a &amp; b right now
 max = c;
 if(d &gt; max) //max has the largest number among a, b, and c
 max = d;

 return(max); //the largest value among a,b,c,d will be returned
}
</code></pre>
<blockquote>
EDIT: I had initially assumed that you were asked to write that code
for positive integers only. However, as <a href="https://stackoverflow.com/users/4756299/andrew-henle">Andrew Henle</a> pointed out,
max = 0 won't work for negative integers, because negative integers will always be less than 0. Hence, max = a is the best
way to proceed. If a turns out to be the largest value, great! If
not, then it'll eventually be replaced by other larger values, and
max will store the largest number in the end. Thank you, Andrew! [Hey, that rhymes! :) ]
 
The others have already pointed out your coding/logical errors, but here's a gist:
</blockquote>
<ul>
<li>Your function is returning 0 irrespective of what you write in the function, above return 0;</li>
<li>Your function is unnecessarily printing some numbers when it should actually return a value. You're essentially assigning the return value to another variable, ans, right?</li>
</ul>

<pre><code>#include &lt;stdio.h&gt;
/*
Add `int max_of_four(int a, int b, int c, int d)` here.
*/
int max_of_four(int a, int b, int c, int d);

int main() 
{
 int a, b, c, d;
 scanf(&quot;%d %d %d %d&quot;, &amp;a, &amp;b, &amp;c, &amp;d);
 int ans = max_of_four(a, b, c, d);
 printf(&quot;%d&quot;, ans);
 
 return 0;
}

int max_of_four(int a, int b, int c, int d)
{
 if (a &gt; b &amp;&amp; a &gt; c &amp;&amp; a &gt; d) {
 printf(&quot;%d\n&quot;, a);
 } else
 if (b &gt; a &amp;&amp; b &gt; c &amp;&amp; b &gt; d) {
 printf(&quot;%d\n&quot;, b);
 } else
 if (c &gt; a &amp;&amp; c &gt; b &amp;&amp; c &gt; d) {
 printf(&quot;%d\n&quot;, c);
 } else {
 printf(&quot;%d\n&quot;, d);
 }
 return 0;
}
</code></pre>
In this question, we have to find out the greatest number among 4 numbers using functions. What is wrong with my code? Why it is not showing the correct output? Please tell me what I am doing wrong and please correct it.

Write a function int max_of_four(int a, int b, int c, int d) which reads four arguments and returns the greatest of them

翻译质量差，导致语言生硬或混乱。

没有提供实际的解决方法或示例。

解答不清晰，无法理解或解决问题。

页面排版不美观，阅读体验差。

文章

问答

视频

学习中心

腾讯云实验室

直播

竞赛

腾讯云代码分析专区

腾讯iOA零信任安全管理系统专区

腾讯云架构师技术同盟交流圈

腾讯云数据库专区

腾讯云顾问专区

腾讯云原生专区

腾讯混元专区

腾讯云TCE专区

腾讯云Lighthouse专区

腾讯云HAI专区

腾讯云Edgeone专区

腾讯云存储专区

腾讯云智能专区

腾讯轻联专区 

腾讯云开发专区

TAPD专区

腾讯轻量云游戏服专区

腾讯云最具价值专家

腾讯云架构师技术同盟

腾讯云创作之星

腾讯云开发者先锋

腾讯云代码助手

云原生构建

TAPD 敏捷项目管理

Cloud Studio

SDK中心

API中心

命令行工具

涵盖代码开发、场景应用、自动测试全流程，助你从零构建专属AI助手

一站式MCP教程库，解锁AI应用新玩法

#include <stdio.h>/*Add `int max_of_four(int a, int b, int c, int d)` here.*/int max_of_four(int a, int b, int c, int d);int main() { int a, b, c, d; scan...

问编写一个函数int max_of_four(int a，int b，int c，int d)，它读取四个参数并返回其中最大的参数。
EN

Stack Overflow用户

社区

活动

圈层

关于

腾讯云开发者

热门产品

热门推荐

更多推荐

问编写一个函数int max_of_four(int a，int b，int c，int d)，它读取四个参数并返回其中最大的参数。EN