我在我的应用程序中实现了邮箱创业板,并认为这应该可以工作,但是得到上面的错误,我认为这与||=操作符有关。
我来接这个
conversations_controller.rb:16: formal argument cannot be an instance variable def
trash_folder @trash ||= current_user.mailbox.trash.all end ^
/home/action/booklist/app/controllers/conversations_controller.rb:16: syntax error,
unexpected tOP_ASGN, expecting ';' or '\n' def trash_folder @trash ||=
current_user.mailbox.trash.all end ^
/home/action/booklist/app/controllers/conversations_controller.rb:18: syntax error, unexpected '.', expecting ';' or '\n' def trash conversation.move_to_trash(current_user)
... ^ /home/action/booklist/app/controllers/conversations_controller.rb:18: syntax
error, unexpected tIDENTIFIER, expecting end-of-input ...rash(current_user) redirect_to
:conversations end ... ^
Conversations_controller:
class ConversationsController < ApplicationController
helper_method :mailbox, :conversation
def index
@conversations ||= current_user.mailbox.inbox.all
end
def reply
current_user.reply_to_conversation(conversation, *message_params(:body, :subject))
redirect_to conversation
end
def trash_folder @trash ||= current_user.mailbox.trash.all end
def trash conversation.move_to_trash(current_user) redirect_to :conversations end
def untrash conversation.untrash(current_user) redirect_to :back end
def empty_trash current_user.mailbox.trash.each do |conversation| conversation.receipts_for(current_user).update_all(:deleted => true)
end
redirect_to :conversations
end
private
def mailbox
@mailbox ||= current_user.mailbox
end
def conversation
@conversation ||= mailbox.conversations.find(params[:id])
end
def conversation_params(*keys)
fetch_params(:conversation, *keys)
end
def message_params(*keys)
fetch_params(:message, *keys)
end
def fetch_params(key, *subkeys)
params[key].instance_eval do
case subkeys.size
when 0 then self
when 1 then self[subkeys.first]
else subkeys.map{|k| self[k] }
end
end
end
会话视图索引:
<% @conversations.each do |conversation| %>
<% if participant != current_user %>
<%= participant.name, participant %>
<% end %>
<%= link_to conversation.subject, conversation %>
<%= conversation.updated_at.strftime("%a, %m/%e/%Y %I:%M %p") %>
<%= link_to "Move to Trash", {:controller => "conversations", :action => "trash", :id => conversation.id}, :title=> "Move to Trash", :method=>'post' %>
<% end %>
并链接到current_user_session路径中的收件箱。
<%= link_to "inbox", conversations_path %>
我有其他的观点,但我认为问题在于谈话负责人。我不知道这些错误是怎么回事,它应该管用
发布于 2014-04-14 21:16:01
将方法定义放在多行上,如下所示:
def trash_folder
@trash ||= current_user.mailbox.trash.all
end
当您将所有内容放在一行时,您的@trash
变量将被解释为一个方法参数。我真的建议不要使用任何一行方法,因为它们很难读懂,而且由于ruby的可选的paren规则,可能会让人感到困惑。
发布于 2014-04-14 21:15:29
如果不使用分号,就不能将方法的内容放在与其def
相同的行中。
如果希望您的方法位于一行上,请将它们重构为如下所示:
def trash_folder; @trash ||= current_user.mailbox.trash.all; end
编辑
我的回答不完全正确。正如J rg在评论中所指出的,在一行上定义一个没有分号的方法是完全可能的。Ruby只需要知道参数列表在哪里完成,方法的主体就开始了。这可以通过使用换行符、分号或空参数列表来实现.
https://stackoverflow.com/questions/23070485
复制相似问题