为什么在OnClickListener的onBindViewHolder中添加RecyclerView.Adapter被认为是错误的做法？
为什么在OnClickListener的onBindViewHolder中添加RecyclerView.Adapter被认为是错误的做法？
提问于 2015-11-21 16:35:52
我有一个RecyclerView.Adapter类的以下代码，它运行得很好：
public class MyAdapter extends RecyclerView.Adapter<MyAdapter.Viewholder> {
private List<Information> items;
private int itemLayout;
public MyAdapter(List<Information> items, int itemLayout){
this.items = items;
this.itemLayout = itemLayout;
}
@Override
public Viewholder onCreateViewHolder(ViewGroup parent, int viewType) {
View v = LayoutInflater.from(parent.getContext()).inflate(itemLayout, parent, false);
return new Viewholder(v);
}
@Override
public void onBindViewHolder(Viewholder holder, final int position) {
Information item = items.get(position);
holder.textView1.setText(item.Title);
holder.textView2.setText(item.Date);
holder.itemView.setOnClickListener(new View.OnClickListener() {
@Override
public void onClick(View view) {
Toast.makeText(view.getContext(), "Recycle Click" + position, Toast.LENGTH_SHORT).show();
}
});
holder.itemView.setOnLongClickListener(new View.OnLongClickListener() {
@Override
public boolean onLongClick(View v) {
Toast.makeText(v.getContext(), "Recycle Click" + position, Toast.LENGTH_SHORT).show();
return true;
}
});
}
@Override
public int getItemCount() {
return items.size();
}
public class Viewholder extends RecyclerView.ViewHolder {
public TextView textView1;
public TextView textView2;
public Viewholder(View itemView) {
super(itemView);
textView1=(TextView) itemView.findViewById(R.id.text1);
textView2 = (TextView) itemView.findViewById(R.id.date_row);
}
}
}但是，我认为在OnClickListener方法中实现onBindViewHolder是不好的做法。为什么这种做法不好，还有什么更好的选择呢？
Stack Overflow用户
发布于 2020-01-02 17:01:56
这就是我如何实现我的按钮在我的ViewHolder，而不是我的onBindViewHolder点击。此示例演示如何使用接口绑定多个按钮，该接口在填充行时不会生成更多对象。
这个例子是西班牙语和Kotlin的，但我相信逻辑是可以理解的。
/**
* Created by Gastón Saillén on 26 December 2019
*/
class DondeComprarRecyclerAdapter(val context:Context,itemListener:RecyclerViewClickListener):RecyclerView.Adapter<BaseViewHolder<*>>() {
interface RecyclerViewClickListener {
fun comoLlegarOnClick(v: View?, position: Int)
fun whatsappOnClick(v:View?,position: Int)
}
companion object{
var itemClickListener: RecyclerViewClickListener? = null
}
init {
itemClickListener = itemListener
}
private var adapterDataList = mutableListOf<Institucion>()
fun setData(institucionesList:MutableList<Institucion>){
this.adapterDataList = institucionesList
}
fun getItemAt(position:Int):Institucion = adapterDataList[position]
override fun onCreateViewHolder(parent: ViewGroup, viewType: Int): BaseViewHolder<*> {
val view = LayoutInflater.from(context)
.inflate(R.layout.dondecomprar_row, parent, false)
return PuntosDeVentaViewHolder(view)
}
override fun getItemCount(): Int {
return if(adapterDataList.size > 0) adapterDataList.size else 0
}
override fun onBindViewHolder(holder: BaseViewHolder<*>, position: Int) {
val element = adapterDataList[position]
when(holder){
is PuntosDeVentaViewHolder -> holder.bind(element)
else -> throw IllegalArgumentException()
}
}
inner class PuntosDeVentaViewHolder(itemView: View):BaseViewHolder<Institucion>(itemView),View.OnClickListener{
override fun bind(item: Institucion) {
itemView.txtTitleDondeComprar.text = item.titulo
itemView.txtDireccionDondeComprar.text = item.direccion
itemView.txtHorarioAtencDondeComprar.text = item.horario
itemView.btnComoLlegar.setOnClickListener(this)
itemView.btnWhatsapp.setOnClickListener(this)
}
override fun onClick(v: View?) {
when(v!!.id){
R.id.btnComoLlegar -> {
itemClickListener?.comoLlegarOnClick(v, adapterPosition)
}
R.id.btnWhatsapp -> {
itemClickListener?.whatsappOnClick(v,adapterPosition)
}
}
}
}
}以及在每个适配器中实现的BaseViewHolder。
/**
* Created by Gastón Saillén on 27 December 2019
*/
abstract class BaseViewHolder<T>(itemView: View) : RecyclerView.ViewHolder(itemView) {
abstract fun bind(item: T)
}页面原文内容由Stack Overflow提供。腾讯云小微IT领域专用引擎提供翻译支持
原文链接：
https://stackoverflow.com/questions/33845846
复制相关文章
相似问题
腾讯云开发者
