这个程序允许用户管理来自多年历史事件的问题和测试用户。我正在寻找关于如何更好地组织代码的建议,可能会将OOP应用于函数,并避免使用全局变量data_filename。
#!/usr/bin/env python3
# -*- coding: utf-8 -*-
from enum import Enum
import os
import pickle
import random
data_filename = 'program.obj'
def read_int(prompt='> ', errmsg='Invalid number!'):
number = None
while number is None:
try:
number = int(input(prompt))
except ValueError:
print(errmsg)
return number
def display_menu():
print('What do you want to do?')
print('[1] List all historical events')
print('[2] Add event')
print('[3] Remove event')
print('[4] Quiz')
print('[5] Statistics')
print('[6] Clear statistics') # TODO: move to options submenu
print('[7] Exit')
def clear_screen():
print(chr(27) + "[2J")
def pause():
input('Press any key to continue...')
def yes_or_no(prompt='Proceed? [y|n]\n> ', errmsg='Valid answers are y and n.'):
answer = input(prompt).strip().lower()
while answer != 'y' and answer != 'n':
print(errmsg)
answer = input(prompt).strip().lower()
return answer
def read_data_file():
file = open(data_filename, 'a+b')
file.seek(0)
data = {'events': [], 'statistics': {'total_successes': 0, 'total_failures': 0}}
if os.path.getsize(data_filename) > 0:
data = pickle.load(file)
file.close()
return data
def list_events(data):
events = data['events']
if len(events) == 0:
print('Event list is empty!')
else:
print('Historical events:')
for event in events:
print(event)
def add_event(data):
events = data['events']
year = read_int(prompt='Enter year: ')
description = input('Enter description: ')
events.append({'year': year, 'description': description})
print('Successfully added a new historical event!')
def remove_event(data):
events = data['events']
if len(events) == 0:
print('Event list is empty!')
else:
for event in events:
print(events.index(event), event)
index = read_int('Which event do you want to delete? ')
try:
events.pop(index)
print('Successfully deleted event!')
except IndexError:
print('Number out of range!')
def quiz(data):
events = data['events']
stats = data['statistics']
if len(events) == 0:
print('Event list is empty!')
else:
num = read_int(prompt='How many questions should I ask? ')
if 0 < num <= len(events):
for event in random.sample(events, num):
print(event['description'])
year = read_int('In which year was following event occurred? ')
if year == event['year']:
stats['total_successes'] += 1
print('Good answer!')
else:
stats['total_failures'] += 1
print('Bad answer!')
elif num < 0:
print('Number of questions can\'t be negative!')
else:
print('Too much questions!')
def display_stats(data):
stats = data['statistics']
tries = stats['total_successes'] + stats['total_failures']
if tries == 0:
total_successes = 0
total_failures = 0
else:
total_successes = stats['total_successes']/tries * 100
total_failures = stats['total_failures']/tries * 100
print('Statistics')
print('Total: {0:10.2f}% successes, {1:10.2f}% failures'.format(total_successes, total_failures))
def clear_stats(data):
answer = yes_or_no('Are you sure you want to clear statistics? [y|n]\n> ')
if answer == 'y':
data['statistics'] = {'total_successes': 0, 'total_failures': 0}
print('Successfully cleared statistics!')
else:
print('Statistics left unchanged.')
# TODO: settings submenu
# def settings(data):
# print('-' * 10)
# print('Program settings')
# print('-' * 10)
# print('[1] Clear statistics')
# print('[2] Back')
# user_choice = read_int()
# while user_choice != 2:
# if user_choice == 1:
# clear_stats(data)
def update_data_file(data):
file = open(data_filename, 'wb')
pickle.dump(data, file)
file.close()
class Choices(Enum):
list_events = 1
add_event = 2
remove_event = 3
quiz = 4
statistics = 5
clear_stats = 6
exit = 7
program_data = read_data_file()
choice = None
while choice != Choices.exit.value:
clear_screen()
display_menu()
choice = read_int()
if choice == Choices.list_events.value:
list_events(program_data)
elif choice == Choices.add_event.value:
add_event(program_data)
elif choice == Choices.remove_event.value:
remove_event(program_data)
elif choice == Choices.quiz.value:
quiz(program_data)
elif choice == Choices.statistics.value:
display_stats(program_data)
elif choice == Choices.clear_stats.value:
clear_stats(program_data)
elif choice == Choices.exit.value:
print('Good bye!')
else:
print('Invalid choice!')
update_data_file(program_data)
pause()发布于 2020-10-17 13:21:32
data_filename应该大写,因为它是一个全局常量。
没有必要使用number作为while的条件,而是:
number = None
while number is None:
try:
number = int(input(prompt))
except ValueError:
print(errmsg)
return number可以是
while True:
try:
return int(input(prompt))
except ValueError:
print(errmsg)display_menu可以使用一个元组序列,更好的是一个命名元组或@dataclasses序列,每个元组都有一个标题字符串属性和一个可调用属性。那么你的display_menu可能是
print('What do you want to do?')
print('\n'.join(f'[{i}] {item.title}' for i, item in enumerate(menu, 1)))我看到你也有一个Choices枚举。这还不错,而且你可以同时使用枚举和上面的建议,只要你有一本关于枚举选择功能引用的字典。
answer != 'y' and answer != 'n'可以是
answer not in {'y', 'n'}避免两次调用input;这是:
answer = input(prompt).strip().lower()
while answer != 'y' and answer != 'n':
print(errmsg)
answer = input(prompt).strip().lower()
return answer可以是
while True:
answer = input(prompt).strip().lower()
if answer in {'y', 'n'}:
return answer
print(errmsg)file = open(data_filename, 'a+b')
file.seek(0)有几个问题:
with并避免显式的close()。data。所以:
if os.path.exists(data_filename):
with open(data_filename, 'rb') as file:
return pickle.load(file)
return {'events': [], 'statistics': {'total_successes': 0, 'total_failures': 0}}if 0 < num <= len(events):
...
elif num < 0:
print('Number of questions can\'t be negative!')
else:
print('Too much questions!')需要重新考虑一下。首先,too much questions应该是too many questions。另外,如果用户输入0怎么办?当然,这不是“太多的问题”,但这才是要打印的。建议:
if num < 1:
print('Not enough questions.')
elif num > len(events):
print('Too many questions.')
else:
...stats['total_successes'] + stats['total_failures']就是我见过的所谓的“数据面食”的例子。在这里,当包含类型提示的@dataclass之类的东西更合适时,字典就会被滥用。
'Total: {0:10.2f}% successes, {1:10.2f}% failures'.format(total_successes, total_failures)更容易表达为
(
f'Total: {total_successes:10.2f}% successes, '
f'{total_failures:10.2f}% failures'
)行分隔是可选的,但对易读性更好。
'Number of questions can\'t be negative!'更容易写成
"Number of questions can't be negative!"https://codereview.stackexchange.com/questions/250781
复制相似问题