前往小程序,Get更优阅读体验!
立即前往
首页
学习
活动
专区
工具
TVP
发布
社区首页 >专栏 >亲身经历:一次sql缺少where条件的惨案,绩效奖金差点没啦~

亲身经历:一次sql缺少where条件的惨案,绩效奖金差点没啦~

作者头像
好好学java
发布2021-03-11 14:20:51
4710
发布2021-03-11 14:20:51
举报

话说那是一个愉快的周五的下午,刚经历双11双黑五12大促连环迎战,一周的工作也接近结束,任务也都要走向提测的节点了,心里美滋滋,可以早点回家啦~

巴特,popo弹出一份:xxx master 的单元测试静态代码检查失败,单元测试失败用例x个。请在1小时内修复并重新执行,否则可能会打回提测,单测失败详情xxx。

点开详情看看失败原因吧~

代码语言:javascript
复制


org.springframework.jdbc.UncategorizedSQLException: 
### Error updating database.  Cause: java.sql.SQLException: It is not allowed to execute a(n) DELETE without where condition, sql:delete from mt_flash_sale_nav
### The error may involve defaultParameterMap
### The error occurred while setting parameters
### SQL: delete from mt_flash_sale_nav
### Cause: java.sql.SQLException: It is not allowed to execute a(n) DELETE without where condition, sql:delete from mt_flash_sale_nav
; uncategorized SQLException for SQL []; SQL state [HY000]; error code [0]; It is not allowed to execute a(n) DELETE without where condition, sql:delete from mt_flash_sale_nav; nested exception is java.sql.SQLException: It is not allowed to execute a(n) DELETE without where condition, sql:delete from mt_flash_sale_nav

瓦特,怎么可能,之前还是好好的呀~ 我没动过这块代码呀~一定是加班太多晃了我的狗眼~本地跑一次还是这样~!GG

赶紧联系DBAbaba们,原来是测试环境qs升级啦!xxx


好吧,扯犊子就到这里了

前段时间测试环境ddb开始限制不带where条件的update/delete的sql语句的执行,单测各种失败,且后续还会在生产环境也会这样,于是开始在工程中各种搜索,人工处理难免有遗漏的可能,怎么地也要用程序全部扫描下才放心呀!

那mybatis是如何解析xml和生成sql的呢,比如这样的sql是如何解析的呢?

代码语言:javascript
复制
 <select id="selectByCond" resultMap="BaseResultMap">
    select    <include refid="Base_Column_List" />
    from test_db    <where>
      <if test="a != null">
        and `a` = #{a}      </if>
      <if test="list != null">
        and b in        <foreach collection="list" open="(" close=")" item="item" separator=",">
          #{item}        </foreach>
      </if>
      order by db_update_time    </where>
  </select>

通过分析mybatis的初始化SqlSessionFactoryBean过程,可以一探究竟。

代码语言:javascript
复制
/**
   * Build a {@code SqlSessionFactory} instance.
   *
   * The default implementation uses the standard MyBatis {@code XMLConfigBuilder} API to build a
   * {@code SqlSessionFactory} instance based on an Reader.
   * Since 1.3.0, it can be specified a {@link Configuration} instance directly(without config file).
   *
   * @return SqlSessionFactory
   * @throws IOException if loading the config file failed
   */
  protected SqlSessionFactory buildSqlSessionFactory() throws IOException {
    // ...
    
    if (!isEmpty(this.mapperLocations)) {
      for (Resource mapperLocation : this.mapperLocations) {
        if (mapperLocation == null) {
          continue;
        }
        try {
          XMLMapperBuilder xmlMapperBuilder = new XMLMapperBuilder(mapperLocation.getInputStream(),
              configuration, mapperLocation.toString(), configuration.getSqlFragments());
          // 这里解析xml
          xmlMapperBuilder.parse();
        } catch (Exception e) {
          throw new NestedIOException("Failed to parse mapping resource: '" + mapperLocation + "'", e);
        } finally {
          ErrorContext.instance().reset();
        }
        if (LOGGER.isDebugEnabled()) {
          LOGGER.debug("Parsed mapper file: '" + mapperLocation + "'");
        }
      }
    } else {
      if (LOGGER.isDebugEnabled()) {
        LOGGER.debug("Property 'mapperLocations' was not specified or no matching resources found");
      }
    }
    return this.sqlSessionFactoryBuilder.build(configuration);
  }

而sql最终如何生成呢?主要靠SqlSource Sql源接口,代表从xml文件或注解映射的sql内容,主要就是用于创建BoundSql,有实现类DynamicSqlSource(动态Sql源),StaticSqlSource(静态Sql源)等:

代码语言:javascript
复制
/**
 * Represents the content of a mapped statement read from an XML file or an annotation. 
 * It creates the SQL that will be passed to the database out of the input parameter received from the user.
 *
 * @author Clinton Begin
 */
public interface SqlSource {
  BoundSql getBoundSql(Object parameterObject);
}

如此,想要打印工程项目中所有sql并判断是否带有where条件就比较明晰了,直接上代码:

代码语言:javascript
复制
    @Resource
    private SqlSessionFactory sqlSessionFactory;
    @Test
    public void test_check() {
        Configuration configuration = sqlSessionFactory.getConfiguration();        System.out.println("#sql.size#" + configuration.getMappedStatements().size());
        Set<String> errors = Sets.newHashSet();
        int i = 1;
        for (Object obj : configuration.getMappedStatements()) {
            if (obj instanceof MappedStatement) {
                MappedStatement mappedStatement = (MappedStatement) obj;                String sql = mappedStatement.getSqlSource().getBoundSql(new SqlParamMap()).getSql();
                sql = sql.replaceAll("\n", "");
                sql = sql.replaceAll("\\s+", " ");
                System.out.println(String.format("#sql,#%02d #%s #%s", i++, mappedStatement.getSqlCommandType(), sql));
                if (!sql.toLowerCase().startsWith("insert") && !sql.toLowerCase().startsWith("select")
                        && !sql.toLowerCase().startsWith("replace")) {
                    if (!sql.toLowerCase().contains("where")) {
                        errors.add(sql);                    }                }            }        }        System.err.println("#error#" + errors.size());
        for (String errorSql : errors) {
            System.err.println(errorSql);        }    }        // 这里为了方便生成sql时,解析入参对象的
    public static class SqlParamMap extends AbstractMap<String, Object> implements Map<String, Object> {
        @Override
        public Set<Entry<String, Object>> entrySet() {
            return Collections.emptySet();
        }
        @Override
        public Object get(Object key) {
            return new Object[] {1, 2};
        }
    }

如此便可打印出不符合条件的sql语句了。比如在我们haitao-matter工程里搜索出:

代码语言:javascript
复制
#error#21
delete from mt_baby_article_config
delete from mt_coupon_center_nav
update mt_auction_goods set price_check_status = 4
delete from mt_spring_label
delete from mt_scene_brand
delete FROM mt_newgoods_content_configupdate mt_auction_goods_edit set price_check_status = 4
DELETE from mt_coupon_center_coupon_info
delete from mt_spring_label_goods
delete from mt_goods_stock_rel
delete from mt_flash_sale_nav
delete from mt_auction_homeshow_inferior
delete from matter_switcher_param_center
delete from mt_mission_award
delete from `mt_newgoods_category_tab_config`
delete from mt_goods_stock_rel_edit
delete from mt_album_label
delete from matter_app_channel_relations
delete from element_user_baby_coupon_info_log
delete from mt_album_label_category

此外还能打印出工程所有sql出来,比如:

代码语言:javascript
复制
#sql,#1974 #DELETE #delete from mt_auction_homeshow_inferior_edit where id=?
#sql,#1975 #SELECT #select id,title,begin_time,end_time,type,status,db_update_time,content from matter_common_schedule WHERE type =? and begin_time <=? and end_time >=? and type = ? order by begin_time limit ?,?
#sql,#1976 #UPDATE #update element_user_baby_coupon_info_log SET award_info=?, create_time=?, update_time=? where id=?
#sql,#1977 #SELECT #SELECT id from mt_auction_goods where show_status!=2
#sql,#1978 #INSERT #insert into TB_ACTIVITY_SHOW_DETAIL_EDIT (id, zone_id, activity_show_id, related_type, related_id, image_url, image_link, sort_order, config,ui_data ) values
#sql,#1979 #SELECT #select id, related_id, goods_id, goods_title, category_id, category_name, advance_price, question_mark_pos, config, sort_order, db_create_time, db_update_time from mt_advance_price_goods_edit where id = ?
#sql,#1980 #SELECT #select id, apply_category_id, apply_brand_id, import_type, db_create_time,db_update_time, status, goods_qa_scheme_edit_id from goods_qa_category_scope_edit where apply_category_id = ? and apply_brand_id = ? and import_type = ? and goods_qa_scheme_edit_id <> ?
#sql,#1981 #SELECT #select id, skin_scheme_id, skin_order, skin_name, skin_introduce, skin_img_config, skin_gif_config, skin_status, operator, db_create_time, db_update_time from mt_private_custom_skin_config_edit where skin_status = ? order by skin_order asc

如此,算是放心不会又遗漏了。整个思路简单直接,其中涉及到mybatis解析xml和生产动态sql的原理和过程的东西有待分析,这里先留个坑,日后来填。

Reference:

  • http://www.mybatis.org/mybatis-3/dynamic-sql.html
  • https://www.cnblogs.com/fangjian0423/p/mybaits-dynamic-sql-analysis.html
代码语言:javascript
复制
本文参与 腾讯云自媒体分享计划,分享自微信公众号。
原始发表:2021-03-10,如有侵权请联系 cloudcommunity@tencent.com 删除

本文分享自 好好学java 微信公众号,前往查看

如有侵权,请联系 cloudcommunity@tencent.com 删除。

本文参与 腾讯云自媒体分享计划  ,欢迎热爱写作的你一起参与!

评论
登录后参与评论
0 条评论
热度
最新
推荐阅读
相关产品与服务
腾讯云代码分析
腾讯云代码分析(内部代号CodeDog)是集众多代码分析工具的云原生、分布式、高性能的代码综合分析跟踪管理平台,其主要功能是持续跟踪分析代码,观测项目代码质量,支撑团队传承代码文化。
领券
问题归档专栏文章快讯文章归档关键词归档开发者手册归档开发者手册 Section 归档