问Envers: Spring项目上的错误审计表
EN

Stack Overflow用户

提问于 2014-09-05 08:26:16

回答 1查看 1.8K关注 0票数 2

我正在将Spring Data JPA 1.6.4与Hibernate 4.3.6.Final + envers一起用于Spring MVC 4.0.7 web应用程序，该应用程序使用Spring Security 3.2.5进行保护。web应用程序部署在使用JNDI数据源配置的Tomcat 7.0.52 web容器上：

<Resource 
              name="jdbc/appDB"
              auth="Container" 
              factory="org.apache.tomcat.jdbc.pool.DataSourceFactory"
              type="javax.sql.DataSource" 
              initialSize="4"
              maxActive="8"
              maxWait="10000"
              maxIdle="8"
              minIdle="4"
              username="user"
              password="password" 
              driverClassName="com.mysql.jdbc.Driver" 
              url="jdbc:mysql://ip/schema?zeroDateTimeBehavior=convertToNull" 
              testOnBorrow="true" 
              testWhileIdle="true" 
              validationQuery="select 1"
              validationInterval="300000" />

数据库运行在MySql服务器版本5.5上，并具有InnoDB架构。

我对审计表Customers_H有一种奇怪的行为:注意到有时审计表被envers以错误的方式填充。大部分时间一切正常。

我不知道发生这种情况的原因和时间，但由于插入了如下的修订表：

ID        ACTION TYPE        REV END        USER
23              0               256          U1
23              2               NULL        NULL
23              0               NULL         U2

奇怪的是，U1是id =6的实体的所有者(而不是id = 23的实体的所有者)，而U2确实在实体ID 23上工作过。问题是修改表是不允许的，然后我有一个Hibernate断言失败。

似乎只有当envers创建了第三行时，它才会正常。但是，为什么它也创建了第一个(与动作创建)和第二个(使用操作删除)？

ERROR org.hibernate.AssertionFailure - HHH000099: an assertion failure occured (this may indicate a bug in Hibernate, but is more likely due to unsafe use of the session): java.lang.RuntimeException: Cannot update previous revision for entity Customer_H and id 23.

这禁止用户更新实体。

我的问题是调查这是怎么发生的！

以下是Customer域：

@SuppressWarnings("serial")
@Entity
@Audited
public class Customer extends AbstractDomain{

    @ManyToOne(optional=false)
    @JoinColumn(updatable=false, nullable=false)
    @JsonIgnore
    private Company company;

    @OneToMany(mappedBy="customer", cascade=CascadeType.REMOVE)
    private Set<Plant> plants = new HashSet<Plant>();

    @Enumerated(EnumType.STRING)
    @Column(nullable=false)
    private CustomerType customerType;

    private String code;

    // other basic fields + getter and settes
}

而Company域与Customer有反向映射。

@OneToMany(mappedBy="company", cascade=CascadeType.REMOVE)
Set<Customer> customers = new HashSet<Customer>();

下面是AbstractDomain类：

@SuppressWarnings("serial")
@MappedSuperclass
@Audited
public abstract class AbstractDomain implements Auditable<String, Long>, Serializable {

    @Id
    @GeneratedValue(strategy=GenerationType.IDENTITY)
    private Long id;    

    @Version
    @JsonIgnore
    private int version;

    @JsonIgnore
    @Column(updatable=false)
    private String createdBy;

    @Type(type="org.jadira.usertype.dateandtime.joda.PersistentDateTime")
    @DateTimeFormat(iso=ISO.DATE_TIME)
    @JsonIgnore
    @Column(updatable=false)
    private DateTime createdDate;

    @JsonIgnore
    private String lastModifiedBy;

    @Type(type="org.jadira.usertype.dateandtime.joda.PersistentDateTime")
    @DateTimeFormat(iso=ISO.DATE_TIME)
    @JsonIgnore
    private DateTime lastModifiedDate;

    public Long getId() {
        return id;
    }
    public void setId(Long id) {
        this.id = id;
    }

    public int getVersion() {
        return version;
    }
    public void setVersion(int version) {
        this.version = version;
    }

    @Override
    public String getCreatedBy() {
        return createdBy;
    }
    @Override
    public void setCreatedBy(String createdBy) {
        this.createdBy = createdBy;
    }

    @Override
    public DateTime getCreatedDate() {
        return createdDate;
    }
    @Override
    public void setCreatedDate(DateTime createdDate) {
        this.createdDate = createdDate;
    }

    @Override
    public String getLastModifiedBy() {
        return lastModifiedBy;
    }
    @Override
    public void setLastModifiedBy(String lastModifiedBy) {
        this.lastModifiedBy = lastModifiedBy;
    }

    @Override
    public DateTime getLastModifiedDate() {
        return lastModifiedDate;
    }
    @Override
    public void setLastModifiedDate(DateTime lastModifiedDate) {
        this.lastModifiedDate = lastModifiedDate;
    }

    @Transient
    @Override
    public final boolean isNew() {
        if (id == null) {
            return true;
        } else {
            return false;
        }
    }   
}

这是CustomerService

@Service
@Repository
@Transactional(readOnly=true)
public class CustomerServiceImpl implements CustomerService{

    @Autowired
    private CustomerRepository customerRepository;

    @Override
    @PostAuthorize("@customerSecurityService.checkAuth(returnObject)")
    public Customer findById(Long id) {
        return customerRepository.findOne(id);
    }

    @Override
    @PreAuthorize("isAuthenticated()")
    @Transactional(readOnly=false)
    public Customer create(Customer entry) {
        entry.setCompany(SecurityUtils.getCustomer().getCompany());
        return customerRepository.save(entry);
    }

    @Override
    @PreAuthorize("@customerSecurityService.checkAuth(#entry)")
    @Transactional(readOnly=false)
    public Customer update(Customer entry) {
        return customerRepository.save(entry);
    }

    ....
}

这是我的CustomerRepository

public interface CustomerRepository extends PagingAndSortingRepository<Customer, Long>,  QueryDslPredicateExecutor<Customer> {

}

在这里，我使用@PreAuthorize @PostAuthorize注释在CustomerService方法中执行安全检查的服务：

@Component
@Transactional(readOnly=true)
public class CustomerSecurityService {

    Logger LOGGER = LoggerFactory.getLogger(CustomerSecurityService.class);

    @Autowired
    private CustomerRepository customerRepository;

    public boolean checkAuth(Customer customer) {
        if(customer == null) {
            LOGGER.error("customer NULL!");
            return false;
        }


        if (customer.getId()==null) {
            return true;
        }


        if (customer.getId()!=null) {
            Customer dbCustomer = customerRepository.findOne(customer.getId());

            if (dbCustomer.getCompany().getId().equals( SecurityUtils.getCustomer().getCompany().getId())){
                return true;
            }else {
                return false;
            }
        }
        return false;
    }

    public boolean checkPage(Page<Customer> pages) {
        for(Customer customer : pages.getContent()) {
            Customer dbCustomer = customerRepository.findOne(customer.getId());

            if (!dbCustomer.getCompany().getId().equals(SecurityUtils.getCustomer().getCompany().getId())){
                return false;
            }
        }
        return true;
    }
}

我的SecurityUtils课程

public class SecurityUtils {

    private SecurityUtils(){}

    private static Logger LOGGER = LoggerFactory.getLogger(SecurityUtils.class);

    public static Customer getCustomer() {
        Customer customer = null;
        if (SecurityContextHolder.getContext().getAuthentication()!=null) {
            customer = ((User)SecurityContextHolder.getContext().getAuthentication().getPrincipal()).getCustomer();
            LOGGER.debug("Customer found: "+customer.getUserName());
        }else {
            LOGGER.debug("Customer not bound.");
        }
        return customer;        
    }


    public static boolean isUserInRole(String role) {
        for (GrantedAuthority grantedAuthority : SecurityContextHolder.getContext().getAuthentication().getAuthorities()) {
            if (grantedAuthority.getAuthority().equals(role)) {
                return true;
            }
        }
        return false;
    }
}

最后是xml配置：

<?xml version="1.0" encoding="UTF-8"?>
<beans xmlns="http://www.springframework.org/schema/beans"
    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
    xmlns:context="http://www.springframework.org/schema/context"
    xmlns:jpa="http://www.springframework.org/schema/data/jpa"
    xmlns:tx="http://www.springframework.org/schema/tx"
    xsi:schemaLocation="http://www.springframework.org/schema/beans http://www.springframework.org/schema/beans/spring-beans-4.0.xsd
        http://www.springframework.org/schema/context http://www.springframework.org/schema/context/spring-context-4.0.xsd
        http://www.springframework.org/schema/data/jpa http://www.springframework.org/schema/data/jpa/spring-jpa-1.3.xsd
        http://www.springframework.org/schema/tx http://www.springframework.org/schema/tx/spring-tx-4.0.xsd">

    <bean id="transactionManager" class="org.springframework.orm.jpa.JpaTransactionManager">
        <property name="entityManagerFactory" ref="emf"/>
    </bean>

    <bean id="hibernateJpaVendorAdapter" class="org.springframework.orm.jpa.vendor.HibernateJpaVendorAdapter" />

    <tx:annotation-driven transaction-manager="transactionManager" />

    <bean id="emf" class="org.springframework.orm.jpa.LocalContainerEntityManagerFactoryBean">
        <property name="dataSource" ref="dataSource" />
        <property name="jpaVendorAdapter" ref="hibernateJpaVendorAdapter" />

        <property name="packagesToScan" value="scan.domain"/>

        <property name="persistenceUnitName" value="persistenceUnit"/>
        <property name="jpaProperties">
            <props>
                <prop key="hibernate.dialect">${hibernate.dialect}</prop>
                <prop key="hibernate.ejb.naming_strategy">org.hibernate.cfg.ImprovedNamingStrategy</prop>
                <!--${hibernate.format_sql} -->
                <prop key="hibernate.format_sql">true</prop>
                <prop key="hibernate.hbm2ddl.auto">${hibernate.hbm2ddl.auto}</prop>
                <!-- ${hibernate.show_sql} -->
                <prop key="hibernate.show_sql">false</prop> 

                <prop key="hibernate.connection.charSet">UTF-8</prop>

                <prop key="hibernate.max_fetch_depth">3</prop>
                <prop key="hibernate.jdbc.fetch_size">50</prop>
                <prop key="hibernate.jdbc.batch_size">20</prop>

                <prop key="jadira.usertype.databaseZone">jvm</prop>

                <prop key="org.hibernate.envers.audit_table_suffix">_H</prop>
                <prop key="org.hibernate.envers.revision_field_name">AUDIT_REVISION</prop>
                <prop key="org.hibernate.envers.revision_type_field_name">ACTION_TYPE</prop>
                <prop key="org.hibernate.envers.audit_strategy">org.hibernate.envers.strategy.ValidityAuditStrategy</prop>
                <prop key="org.hibernate.envers.audit_strategy_validity_end_rev_field_name">AUDIT_REVISION_END</prop>
                <prop key="org.hibernate.envers.audit_strategy_validity_store_revend_timestamp">True</prop>
                <prop key="org.hibernate.envers.audit_strategy_validity_revend_timestamp_field_name">AUDIT_REVISION_END_TS</prop>               
            </props>
        </property>
    </bean>

    <jpa:repositories base-package="scan.repository"
                      entity-manager-factory-ref="emf"
                      transaction-manager-ref="transactionManager"/>

    <jpa:auditing auditor-aware-ref="auditorAwareBean" />

    <bean id="auditorAwareBean" class="auditor.AuditorAwareBean"/>

</beans>